fix: running single seeder is so slow#944
Merged
WikiRik merged 1 commit intosequelize:mainfrom Nov 29, 2021
Merged
Conversation
a60814billy
changed the title
|
/cc @sushantdhiman @sdepold Anything blocking this? Is the project still active? |
|
/cc @papb (as you seem to have the last active contributor) |
WikiRik
approved these changes
Nov 6, 2021
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
@sdepold this looks good to me, the tests also pass after rebasing on my fork; https://github.com/WikiRik/cli/actions/runs/1429024655
Member
|
I wonder which option is turned off that I cannot rebase through the ui |
a60814billy
force-pushed
the
fix/seed-slow
branch
from
e8f1a7b to
33b8101
Compare
Contributor
Author
|
Hi @sdepold , I'm rebased to latest main branch. |
|
🎉 This PR is included in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testpass with this change (including linting)?Description of change
fixed #943
about test failed
The
npm run testhas 2 faileds.First one is on prettier (in file
test/support/helpers.js), but I didn't change this file.Second one is on
1) [SQLITE] lib/sequelize model:create->attributes->--attributes first_name:string,last_name:string,bio:text,role:enum:{Admin,"Guest User"},reviews:array:text exits with exit code 0:, but this test case also failed in master branch.I think those test failed is not about my changes.