fix(openai-v2): accept APITimeoutError in bad-endpoint tests for Windows

On Windows, connecting to localhost:4242 with timeout=0.1s raises
APITimeoutError (TCP SYN retries) instead of APIConnectionError
(immediate ECONNREFUSED on Unix). Both indicate unreachable endpoint.

Made-with: Cursor

Author: adityamehra

instrumentation-genai/opentelemetry-instrumentation-openai-v2/tests/test_async_chat_completions.py

@@ -128,8 +128,9 @@ async def test_async_chat_completion_bad_endpoint(
         spans[0], llm_model_value, server_address="localhost"
     )
     assert 4242 == spans[0].attributes[ServerAttributes.SERVER_PORT]
-    assert (
-        "APIConnectionError" == spans[0].attributes[ErrorAttributes.ERROR_TYPE]
+    assert spans[0].attributes[ErrorAttributes.ERROR_TYPE] in (
+        "APIConnectionError",
+        "APITimeoutError",
     )
 
 

instrumentation-genai/opentelemetry-instrumentation-openai-v2/tests/test_chat_completions.py

@@ -176,8 +176,9 @@ def test_chat_completion_bad_endpoint(
         spans[0], llm_model_value, server_address="localhost"
     )
     assert 4242 == spans[0].attributes[ServerAttributes.SERVER_PORT]
-    assert (
-        "APIConnectionError" == spans[0].attributes[ErrorAttributes.ERROR_TYPE]
+    assert spans[0].attributes[ErrorAttributes.ERROR_TYPE] in (
+        "APIConnectionError",
+        "APITimeoutError",
     )
 
     metrics = metric_reader.get_metrics_data().resource_metrics
@@ -194,12 +195,9 @@ def test_chat_completion_bad_endpoint(
     )
     assert duration_metric is not None
     assert duration_metric.data.data_points[0].sum > 0
-    assert (
-        duration_metric.data.data_points[0].attributes[
-            ErrorAttributes.ERROR_TYPE
-        ]
-        == "APIConnectionError"
-    )
+    assert duration_metric.data.data_points[0].attributes[
+        ErrorAttributes.ERROR_TYPE
+    ] in ("APIConnectionError", "APITimeoutError")
 
 
 @pytest.mark.vcr()

instrumentation-genai/opentelemetry-instrumentation-openai-v2/tests/test_embeddings.py

@@ -214,8 +214,9 @@ def test_embeddings_bad_endpoint(
         server_address="localhost",
     )
     assert 4242 == spans[0].attributes[ServerAttributes.SERVER_PORT]
-    assert (
-        "APIConnectionError" == spans[0].attributes[ErrorAttributes.ERROR_TYPE]
+    assert spans[0].attributes[ErrorAttributes.ERROR_TYPE] in (
+        "APIConnectionError",
+        "APITimeoutError",
     )
 
     # Verify metrics
@@ -233,12 +234,9 @@ def test_embeddings_bad_endpoint(
     )
     assert duration_metric is not None
     assert duration_metric.data.data_points[0].sum > 0
-    assert (
-        duration_metric.data.data_points[0].attributes[
-            ErrorAttributes.ERROR_TYPE
-        ]
-        == "APIConnectionError"
-    )
+    assert duration_metric.data.data_points[0].attributes[
+        ErrorAttributes.ERROR_TYPE
+    ] in ("APIConnectionError", "APITimeoutError")
 
 
 @pytest.mark.vcr()