fix: update to .NET 10 SDK and workaround for platform regression in Traits (#213, #211, #212)

codito · web-flow · commit eb36b5cf67dc · 2025-12-13T20:30:18.000+05:30
* fix: update to .NET 10 SDK and workaround for platform regression in Traits

* test: replace netcoreapp3.1 with last LTS net8.0

* fix: mark projects explicitly packable by dotnet pack

* chore: mstest version for vstest classic

* chore: latest mstest

* test: remove assets build for acceptance tests
diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -50,14 +50,14 @@ jobs:
       TERM: "xterm"
     steps:
       - uses: actions/checkout@v4
-      - name: Setup .NET 9.0
+      - name: Setup .NET 10.0
         uses: actions/setup-dotnet@v1
         with:
-          dotnet-version: 9.x
-      - name: Setup .NET 3.1.x
+          dotnet-version: 10.x
+      - name: Setup .NET 8.x
         uses: actions/setup-dotnet@v1
         with:
-          dotnet-version: "3.1.x"
+          dotnet-version: "8.x"
       - name: Configure NuGet cache
         uses: actions/cache@v3
         with:
@@ -93,8 +93,8 @@ jobs:
             **/test-results-*.xml
             **/test-results-*.json
             **/*.log
-            test/assets/**/bin/Debug/netcoreapp3.1/
-            test/assets/**/bin/Debug/net9.0/
+            test/assets/**/bin/Debug/net8.0/
+            test/assets/**/bin/Debug/net10.0/
       - name: Codecov
         uses: codecov/codecov-action@v3.1.0
         with:
diff --git a/src/JUnit.Xml.Package/JUnit.Xml.Package.csproj b/src/JUnit.Xml.Package/JUnit.Xml.Package.csproj
@@ -2,6 +2,7 @@
 
   <PropertyGroup>
     <PackageIcon>packageIcon.png</PackageIcon>
+    <IsPackable>true</IsPackable>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/src/NUnit.Xml.Package/NUnit.Xml.Package.csproj b/src/NUnit.Xml.Package/NUnit.Xml.Package.csproj
@@ -4,6 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <Version>$(PackageVersion)</Version>
     <AssemblyName>NUnitXml.TestLogger</AssemblyName>
+    <IsPackable>true</IsPackable>
 
     <!-- This isn't an assembly -->
     <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
diff --git a/src/TestLogger/Core/TestRunResultWorkflow.cs b/src/TestLogger/Core/TestRunResultWorkflow.cs
@@ -159,6 +159,8 @@ string x when x.Equals("Legacy", StringComparison.OrdinalIgnoreCase) => legacyPa
             var attachments = result.Attachments.SelectMany(x => x.ToAttachments(baseDirectory: GetTestResultDirectory(testRun), makeRelativePaths: testRun.LoggerConfiguration.UseRelativeAttachmentPaths)).ToList();
 
             Func<string, string> sanitize = testRun.Serializer.InputSanitizer.Sanitize;
+
+            var traits = GetTraits(result.TestCase, sanitize);
             testRun.Store.Add(new TestResultInfo(
                 sanitize(parsedName.Namespace),
                 sanitize(parsedName.Type),
@@ -177,7 +179,7 @@ string x when x.Equals("Legacy", StringComparison.OrdinalIgnoreCase) => legacyPa
                 sanitize(result.ErrorStackTrace),
                 result.Messages.Select(x => new TestResultMessage(sanitize(x.Category), sanitize(x.Text))).ToList(),
                 attachments,
-                result.TestCase.Traits.Select(x => new Trait(sanitize(x.Name), sanitize(x.Value))).ToList(),
+                traits,
                 result.TestCase.ExecutorUri?.ToString(),
                 result.TestCase));
         }
@@ -188,5 +190,24 @@ private static string GetTestResultDirectory(ITestRun testRun)
                 .GetFormattedLogFilePath(testRun.RunConfiguration);
             return Path.GetDirectoryName(logFilePath);
         }
+
+        private static List<Trait> GetTraits(TestCase testCase, Func<string, string> sanitize)
+        {
+            // Workaround for test platform regression in .NET 10 SDK
+            // var traits = result.TestCase.Traits.Select(x => new Trait(sanitize(x.Name), sanitize(x.Value))).ToList();
+            var traits = new List<Trait>();
+            var traitProperty = testCase.Properties.FirstOrDefault(p => p.Id == "TestObject.Traits");
+            if (traitProperty != null)
+            {
+                var traitValues = testCase.GetPropertyValue(traitProperty, Enumerable.Empty<KeyValuePair<string, string>>());
+
+                foreach (var kvp in traitValues)
+                {
+                    traits.Add(new Trait(sanitize(kvp.Key), sanitize(kvp.Value)));
+                }
+            }
+
+            return traits;
+        }
     }
 }
diff --git a/src/Xunit.Xml.Package/Xunit.Xml.Package.csproj b/src/Xunit.Xml.Package/Xunit.Xml.Package.csproj
@@ -4,6 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <Version>$(PackageVersion)</Version>
     <AssemblyName>XunitXml.TestLogger</AssemblyName>
+    <IsPackable>true</IsPackable>  
 
     <!-- This isn't an assembly -->
     <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
diff --git a/test/JUnit.Xml.TestLogger.AcceptanceTests/JUnit.Xml.TestLogger.AcceptanceTests.csproj b/test/JUnit.Xml.TestLogger.AcceptanceTests/JUnit.Xml.TestLogger.AcceptanceTests.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <WarningsAsErrors>true</WarningsAsErrors>
     <EnableCodeAnalysis>true</EnableCodeAnalysis>
     <IsPackable>false</IsPackable>
diff --git a/test/JUnit.Xml.TestLogger.AcceptanceTests/JUnitTestLoggerPathTests.cs b/test/JUnit.Xml.TestLogger.AcceptanceTests/JUnitTestLoggerPathTests.cs
@@ -19,8 +19,8 @@ public class JUnitTestLoggerPathTests
     {
         private static readonly string[] ExpectedResultsFiles = new string[]
         {
-            "JUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp90.test-results.xml",
-            "JUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp31.test-results.xml"
+            "JUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp100.test-results.xml",
+            "JUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp80.test-results.xml"
         };
 
         [TestMethod]
diff --git a/test/JUnit.Xml.TestLogger.UnitTests/JUnit.Xml.TestLogger.UnitTests.csproj b/test/JUnit.Xml.TestLogger.UnitTests/JUnit.Xml.TestLogger.UnitTests.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <WarningsAsErrors>true</WarningsAsErrors>
     <EnableCodeAnalysis>true</EnableCodeAnalysis>
     <IsPackable>false</IsPackable>
diff --git a/test/Json.TestLogger.Package/Json.TestLogger.Package.csproj b/test/Json.TestLogger.Package/Json.TestLogger.Package.csproj
@@ -4,6 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <Version>$(PackageVersion)</Version>
     <AssemblyName>Sample.Json.TestLogger</AssemblyName>
+    <IsPackable>true</IsPackable>
 
     <!-- This isn't an assembly -->
     <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
diff --git a/test/NUnit.Xml.TestLogger.AcceptanceTests/NUnit.Xml.TestLogger.AcceptanceTests.csproj b/test/NUnit.Xml.TestLogger.AcceptanceTests/NUnit.Xml.TestLogger.AcceptanceTests.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <WarningsAsErrors>true</WarningsAsErrors>
     <EnableCodeAnalysis>true</EnableCodeAnalysis>
     <IsPackable>false</IsPackable>
diff --git a/test/NUnit.Xml.TestLogger.AcceptanceTests/NUnitTestLoggerAcceptanceTests.cs b/test/NUnit.Xml.TestLogger.AcceptanceTests/NUnitTestLoggerAcceptanceTests.cs
@@ -109,7 +109,7 @@ public void TestResultFileShouldContainAssemblyTestSuite(string resultFileName)
 
             Assert.AreEqual("Failed", node.Attribute(XName.Get("result")).Value);
             Assert.AreEqual("NUnit.Xml.TestLogger.NetCore.Tests.dll", node.Attribute(XName.Get("name")).Value);
-            Assert.AreEqual(AssetName.ToAssetAssemblyPath("netcoreapp3.1"), node.Attribute(XName.Get("fullname")).Value);
+            Assert.AreEqual(AssetName.ToAssetAssemblyPath("net8.0"), node.Attribute(XName.Get("fullname")).Value);
 
             var startTimeStr = node.Attribute(XName.Get("start-time"))?.Value;
             var endTimeStr = node.Attribute(XName.Get("end-time"))?.Value;
diff --git a/test/NUnit.Xml.TestLogger.AcceptanceTests/NUnitTestLoggerPathTests.cs b/test/NUnit.Xml.TestLogger.AcceptanceTests/NUnitTestLoggerPathTests.cs
@@ -14,8 +14,8 @@ public class NUnitTestLoggerPathTests
     {
         private static readonly string[] ExpectedResultsFiles = new string[]
         {
-            "NUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp90.test-results.xml",
-            "NUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp31.test-results.xml"
+            "NUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp100.test-results.xml",
+            "NUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp80.test-results.xml"
         };
 
         [TestMethod]
diff --git a/test/NUnit.Xml.TestLogger.UnitTests/NUnit.Xml.TestLogger.UnitTests.csproj b/test/NUnit.Xml.TestLogger.UnitTests/NUnit.Xml.TestLogger.UnitTests.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <WarningsAsErrors>true</WarningsAsErrors>
     <EnableCodeAnalysis>true</EnableCodeAnalysis>
     <IsPackable>false</IsPackable>
diff --git a/test/TestLogger.AcceptanceTests/Snapshots/TestLoggerAcceptanceTests/VerifyTestRunOutput/Json.TestLogger.MSTest.NetCore.Tests.verified.txt b/test/TestLogger.AcceptanceTests/Snapshots/TestLoggerAcceptanceTests/VerifyTestRunOutput/Json.TestLogger.MSTest.NetCore.Tests.verified.txt
@@ -1,6 +1,6 @@
 ﻿[
   {
-    Name: bin/Debug/netcoreapp3.1/Json.TestLogger.MSTest.NetCore.Tests.dll,
+    Name: bin/Debug/net8.0/Json.TestLogger.MSTest.NetCore.Tests.dll,
     Fixtures: [
       {
         Name: UnitTest1,
diff --git a/test/TestLogger.AcceptanceTests/Snapshots/TestLoggerAcceptanceTests/VerifyTestRunOutput/Json.TestLogger.NUnit.NetCore.Tests-;Parser=Legacy-IncludesParserFailures.verified.txt b/test/TestLogger.AcceptanceTests/Snapshots/TestLoggerAcceptanceTests/VerifyTestRunOutput/Json.TestLogger.NUnit.NetCore.Tests-;Parser=Legacy-IncludesParserFailures.verified.txt
@@ -1,6 +1,6 @@
 ﻿[
   {
-    Name: bin/Debug/netcoreapp3.1/Json.TestLogger.NUnit.NetCore.Tests.dll,
+    Name: bin/Debug/net8.0/Json.TestLogger.NUnit.NetCore.Tests.dll,
     Fixtures: [
       {
         Name: Issue28_Examples,
diff --git a/test/TestLogger.AcceptanceTests/Snapshots/TestLoggerAcceptanceTests/VerifyTestRunOutput/Json.TestLogger.NUnit.NetCore.Tests.verified.txt b/test/TestLogger.AcceptanceTests/Snapshots/TestLoggerAcceptanceTests/VerifyTestRunOutput/Json.TestLogger.NUnit.NetCore.Tests.verified.txt
@@ -1,6 +1,6 @@
 ﻿[
   {
-    Name: bin/Debug/netcoreapp3.1/Json.TestLogger.NUnit.NetCore.Tests.dll,
+    Name: bin/Debug/net8.0/Json.TestLogger.NUnit.NetCore.Tests.dll,
     Fixtures: [
       {
         Name: Issue28_Examples,
diff --git a/test/TestLogger.AcceptanceTests/Snapshots/TestLoggerAcceptanceTests/VerifyTestRunOutput/Json.TestLogger.XUnit.NetCore.Tests.verified.txt b/test/TestLogger.AcceptanceTests/Snapshots/TestLoggerAcceptanceTests/VerifyTestRunOutput/Json.TestLogger.XUnit.NetCore.Tests.verified.txt
@@ -1,6 +1,6 @@
 ﻿[
   {
-    Name: bin/Debug/netcoreapp3.1/Json.TestLogger.XUnit.NetCore.Tests.dll,
+    Name: bin/Debug/net8.0/Json.TestLogger.XUnit.NetCore.Tests.dll,
     Fixtures: [
       {
         Name: UnitTest1,
diff --git a/test/TestLogger.AcceptanceTests/TestLogger.AcceptanceTests.csproj b/test/TestLogger.AcceptanceTests/TestLogger.AcceptanceTests.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFramework>net9.0</TargetFramework>
+        <TargetFramework>net10.0</TargetFramework>
         <WarningsAsErrors>true</WarningsAsErrors>
         <EnableCodeAnalysis>true</EnableCodeAnalysis>
         <IsPackable>false</IsPackable>
@@ -21,20 +21,6 @@
         <PackageReference Include="Verify.MSTest" />
     </ItemGroup>
 
-    <!-- Build test assets for acceptance tests -->
-    <ItemGroup>
-        <TestAssets Include="$(MSBuildThisFileDirectory)../assets/Json.TestLogger.MSTest.NetCore.Tests/Json.TestLogger.MSTest.NetCore.Tests.csproj" />
-        
-        <TestAssets Include="$(MSBuildThisFileDirectory)../assets/Json.TestLogger.NUnit.NetCore.Tests/Json.TestLogger.NUnit.NetCore.Tests.csproj" />
-
-        <TestAssets Include="$(MSBuildThisFileDirectory)../assets/Json.TestLogger.XUnit.NetCore.Tests/Json.TestLogger.XUnit.NetCore.Tests.csproj" />
-    </ItemGroup>
-    <Target Name="TestTarget" BeforeTargets="Build">
-        <Message Importance="High" Text="... Building test assets" />
-        <MSBuild Projects="@(TestAssets)" Properties="Configuration=$(Configuration)" Targets="Restore;Build" />
-        <Message Importance="High" Text="... Completed" />
-    </Target>
-
     <ItemGroup>
         <ProjectReference Include="..\Json.TestLogger\Json.TestLogger.csproj" />
         <ProjectReference Include="..\TestLogger.Fixtures\TestLogger.Fixtures.csproj" />
diff --git a/test/TestLogger.Fixtures/DotnetTestFixture.cs b/test/TestLogger.Fixtures/DotnetTestFixture.cs
@@ -9,7 +9,7 @@ namespace TestLogger.Fixtures
 
     public class DotnetTestFixture
     {
-        private const string NetcoreVersion = "netcoreapp3.1";
+        private const string NetcoreVersion = "net8.0";
         private bool buildProject = false;
         private bool cleanProject = false;
         private string relativeResultsDirectory = string.Empty;
@@ -109,9 +109,6 @@ public string Execute(string assemblyName, string loggerArgs, bool collectCovera
 
             this.LogTestAssetOutDir(assemblyName);
 
-            // Required to skip icu requirement for netcoreapp3.1 in linux
-            dotnet.StartInfo.EnvironmentVariables["DOTNET_SYSTEM_GLOBALIZATION_INVARIANT"] = "1";
-
             Console.WriteLine("\n\n## Test run arguments: dotnet " + dotnet.StartInfo.Arguments);
 
             // To avoid deadlocks, always read the output stream first and then wait.
diff --git a/test/TestLogger.Fixtures/TestLogger.Fixtures.csproj b/test/TestLogger.Fixtures/TestLogger.Fixtures.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>
diff --git a/test/TestLogger.PackageTests/TestLogger.PackageTests.csproj b/test/TestLogger.PackageTests/TestLogger.PackageTests.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFramework>net9.0</TargetFramework>
+        <TargetFramework>net10.0</TargetFramework>
         <WarningsAsErrors>true</WarningsAsErrors>
         <EnableCodeAnalysis>true</EnableCodeAnalysis>
         <IsPackable>false</IsPackable>
diff --git a/test/TestLogger.UnitTests/TestLogger.UnitTests.csproj b/test/TestLogger.UnitTests/TestLogger.UnitTests.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <WarningsAsErrors>true</WarningsAsErrors>
     <EnableCodeAnalysis>true</EnableCodeAnalysis>
     <IsPackable>false</IsPackable>
diff --git a/test/Xunit.Xml.TestLogger.AcceptanceTests/TestRunFixture.cs b/test/Xunit.Xml.TestLogger.AcceptanceTests/TestRunFixture.cs
@@ -8,7 +8,7 @@ namespace Xunit.Xml.TestLogger.AcceptanceTests
 
     public class TestRunFixture : IDisposable
     {
-        private const string DotnetVersion = "netcoreapp3.1";
+        private const string DotnetVersion = "net8.0";
 
         public TestRunFixture()
         {
diff --git a/test/Xunit.Xml.TestLogger.AcceptanceTests/Xunit.Xml.TestLogger.AcceptanceTests.csproj b/test/Xunit.Xml.TestLogger.AcceptanceTests/Xunit.Xml.TestLogger.AcceptanceTests.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <WarningsAsErrors>true</WarningsAsErrors>
     <EnableCodeAnalysis>true</EnableCodeAnalysis>
     <IsPackable>false</IsPackable>
diff --git a/test/assets/Directory.Build.props b/test/assets/Directory.Build.props
@@ -3,8 +3,10 @@
   <PropertyGroup>
     <RunAnalyzers>false</RunAnalyzers>
 
-    <!-- https://github.com/dotnet/sdk/issues/37636 -->
-    <NoWarn>$(NoWarn);NETSDK1188</NoWarn>
+    <!-- https://github.com/dotnet/sdk/issues/37636 
+    NU1903: known vulnerability in dependency warning doesn't make sense in test assets
+    -->
+    <NoWarn>$(NoWarn);NETSDK1188;NU1903</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup>
@@ -16,7 +18,7 @@
     <XunitV3TestAdapterVersion>3.0.2</XunitV3TestAdapterVersion>
     <NUnitVersion>3.13.2</NUnitVersion>
     <NUnitTestAdapterVersion>4.0.0</NUnitTestAdapterVersion>
-    <MSTestVersion>3.4.3</MSTestVersion>
+    <MSTestVersion>3.0.4</MSTestVersion>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(IsMTP)' == 'true'">
diff --git a/test/assets/JUnit.Xml.PackageTest/JUnit.Xml.PackageTest.csproj b/test/assets/JUnit.Xml.PackageTest/JUnit.Xml.PackageTest.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
 
diff --git a/test/assets/JUnit.Xml.TestLogger.NetCore.Tests/JUnit.Xml.TestLogger.NetCore.Tests.csproj b/test/assets/JUnit.Xml.TestLogger.NetCore.Tests/JUnit.Xml.TestLogger.NetCore.Tests.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
 
     <!-- Disable stylecop for test assets -->
     <StylecopEnabled>false</StylecopEnabled>
diff --git a/test/assets/JUnit.Xml.TestLogger.NetMulti.Tests/JUnit.Xml.TestLogger.NetMulti.Tests.csproj b/test/assets/JUnit.Xml.TestLogger.NetMulti.Tests/JUnit.Xml.TestLogger.NetMulti.Tests.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net9.0;netcoreapp3.1</TargetFrameworks>
+    <TargetFrameworks>net10.0;net8.0</TargetFrameworks>
 
     <!-- Disable stylecop for test assets -->
     <StylecopEnabled>false</StylecopEnabled>
diff --git a/test/assets/JUnit.Xml.TestLogger.XUnit.NetCore.Tests/JUnit.Xml.TestLogger.XUnit.NetCore.Tests.csproj b/test/assets/JUnit.Xml.TestLogger.XUnit.NetCore.Tests/JUnit.Xml.TestLogger.XUnit.NetCore.Tests.csproj
@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
-    <TargetFramework Condition="'$(UsesXunit3)'=='true'">net9.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework Condition="'$(UsesXunit3)'=='true'">net10.0</TargetFramework>
     <!-- Disable stylecop for test assets -->
     <StylecopEnabled>false</StylecopEnabled>
   </PropertyGroup>
diff --git a/test/assets/Json.TestLogger.MSTest.NetCore.Tests/AttachmentTest.cs b/test/assets/Json.TestLogger.MSTest.NetCore.Tests/AttachmentTest.cs
@@ -8,7 +8,7 @@ namespace NUnit.Xml.TestLogger.Tests2
     public class AttachmentTest
     {
         public TestContext TestContext { get; set; }
-        
+
         [TestMethod]
         public void TestAddAttachment()
         {
diff --git a/test/assets/Json.TestLogger.MSTest.NetCore.Tests/Json.TestLogger.MSTest.NetCore.Tests.csproj b/test/assets/Json.TestLogger.MSTest.NetCore.Tests/Json.TestLogger.MSTest.NetCore.Tests.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
 
     <!-- Disable stylecop for test assets -->
     <StylecopEnabled>false</StylecopEnabled>
diff --git a/test/assets/Json.TestLogger.NUnit.NetCore.Tests/Json.TestLogger.NUnit.NetCore.Tests.csproj b/test/assets/Json.TestLogger.NUnit.NetCore.Tests/Json.TestLogger.NUnit.NetCore.Tests.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
 
     <!-- Disable stylecop for test assets -->
     <StylecopEnabled>false</StylecopEnabled>
diff --git a/test/assets/Json.TestLogger.XUnit.NetCore.Tests/Json.TestLogger.XUnit.NetCore.Tests.csproj b/test/assets/Json.TestLogger.XUnit.NetCore.Tests/Json.TestLogger.XUnit.NetCore.Tests.csproj
@@ -1,8 +1,8 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
-    <TargetFramework Condition="'$(UsesXunit3)'=='true'">net9.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework Condition="'$(UsesXunit3)'=='true'">net10.0</TargetFramework>
     <!-- Disable stylecop for test assets -->
     <StylecopEnabled>false</StylecopEnabled>
   </PropertyGroup>
diff --git a/test/assets/NUnit.Xml.PackageTest/NUnit.Xml.PackageTest.csproj b/test/assets/NUnit.Xml.PackageTest/NUnit.Xml.PackageTest.csproj
diff --git a/test/assets/NUnit.Xml.TestLogger.NetCore.Tests/NUnit.Xml.TestLogger.NetCore.Tests.csproj b/test/assets/NUnit.Xml.TestLogger.NetCore.Tests/NUnit.Xml.TestLogger.NetCore.Tests.csproj
diff --git a/test/assets/NUnit.Xml.TestLogger.NetMulti.Tests/NUnit.Xml.TestLogger.NetMulti.Tests.csproj b/test/assets/NUnit.Xml.TestLogger.NetMulti.Tests/NUnit.Xml.TestLogger.NetMulti.Tests.csproj
diff --git a/test/assets/Xunit.Xml.PackageTest/Xunit.Xml.PackageTest.csproj b/test/assets/Xunit.Xml.PackageTest/Xunit.Xml.PackageTest.csproj
diff --git a/test/assets/Xunit.Xml.TestLogger.NetCore.Tests/Xunit.Xml.TestLogger.NetCore.Tests.csproj b/test/assets/Xunit.Xml.TestLogger.NetCore.Tests/Xunit.Xml.TestLogger.NetCore.Tests.csproj
diff --git a/testlogger.sln b/testlogger.sln
diff --git a/testlogger.slnx b/testlogger.slnx

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,8 @@ public class JUnitTestLoggerPathTests`
`19`	`19`	`{`
`20`	`20`	`private static readonly string[] ExpectedResultsFiles = new string[]`
`21`	`21`	`{`
`22`		`- "JUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp90.test-results.xml",`
`23`		`- "JUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp31.test-results.xml"`
	`22`	`+ "JUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp100.test-results.xml",`
	`23`	`+ "JUnit.Xml.TestLogger.NetMulti.Tests.NETCoreApp80.test-results.xml"`
`24`	`24`	`};`
`25`	`25`
`26`	`26`	`[TestMethod]`