Skip to content

Conversation

@kyrie25
Copy link
Member

@kyrie25 kyrie25 commented Aug 31, 2025

Tested on .46, .64, .70, .71

Summary by CodeRabbit

  • Bug Fixes
    • Restored compatibility with recent app updates to ensure context menus load correctly.
    • Fixed an issue where right-click menus could fail to appear, making actions accessible again.
    • Improved reliability of context menu rendering across the interface.

@kyrie25 kyrie25 requested a review from rxri August 31, 2025 14:01
@coderabbitai
Copy link

coderabbitai bot commented Aug 31, 2025

Walkthrough

Updated a string predicate used to detect the webpack chunk for resolving Spicetify.ReactComponent.ContextMenu, switching from "toggleContextMenu" to "handleContextMenu". No other logic, exports, or error handling paths were changed.

Changes

Cohort / File(s) Summary
Webpack chunk detection
jsHelper/spicetifyWrapper.js
Changed the predicate in the chunk matcher from .includes("toggleContextMenu") to .includes("handleContextMenu") for resolving Spicetify.ReactComponent.ContextMenu. No other code modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A bunny taps code with a gentle thrum,
Switches a string—what may come?
From toggle to handle, a subtle cue,
The menu now hops to a path more true.
Ears perked high, I ship and run—
One tiny nibble, and the build is done. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/context-menu

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
jsHelper/spicetifyWrapper.js (2)

896-896: Keep compatibility across Spotify builds (add fallback for old predicate).

Support both “handleContextMenu” (new) and “toggleContextMenu” (old) to avoid regressions on versions before the rename.

Apply:

-	const contextMenuChunk = chunks.find(([, value]) => value.toString().includes("handleContextMenu"));
+	// tolerate rename across versions
+	const contextMenuChunk =
+		chunks.find(([, value]) => value.toString().includes("handleContextMenu")) ??
+		chunks.find(([, value]) => value.toString().includes("toggleContextMenu"));

897-899: Harden export resolution (handle both function and .render exports).

Some chunks export a component wrapper whose entry is at .render. Add a small fallback so ContextMenu resolves reliably.

-	if (contextMenuChunk) {
-		Spicetify.ReactComponent.ContextMenu = Object.values(require(contextMenuChunk[0])).find((m) => typeof m === "function");
-	}
+	if (contextMenuChunk) {
+		const mod = require(contextMenuChunk[0]);
+		Spicetify.ReactComponent.ContextMenu =
+			Object.values(mod)?.[0]?.render ??
+			Object.values(mod).find((m) => typeof m === "function");
+	}
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 561c9df and 084e685.

📒 Files selected for processing (1)
  • jsHelper/spicetifyWrapper.js (1 hunks)

@rxri rxri merged commit c2d2ef3 into main Sep 1, 2025
8 checks passed
@rxri rxri deleted the fix/context-menu branch September 1, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants