-
-
Notifications
You must be signed in to change notification settings - Fork 832
fix(react-component): hook correct ContextMenu
#3501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3b30f1b to
084e685
Compare
WalkthroughUpdated a string predicate used to detect the webpack chunk for resolving Spicetify.ReactComponent.ContextMenu, switching from "toggleContextMenu" to "handleContextMenu". No other logic, exports, or error handling paths were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
jsHelper/spicetifyWrapper.js (2)
896-896: Keep compatibility across Spotify builds (add fallback for old predicate).Support both “handleContextMenu” (new) and “toggleContextMenu” (old) to avoid regressions on versions before the rename.
Apply:
- const contextMenuChunk = chunks.find(([, value]) => value.toString().includes("handleContextMenu")); + // tolerate rename across versions + const contextMenuChunk = + chunks.find(([, value]) => value.toString().includes("handleContextMenu")) ?? + chunks.find(([, value]) => value.toString().includes("toggleContextMenu"));
897-899: Harden export resolution (handle both function and .render exports).Some chunks export a component wrapper whose entry is at .render. Add a small fallback so ContextMenu resolves reliably.
- if (contextMenuChunk) { - Spicetify.ReactComponent.ContextMenu = Object.values(require(contextMenuChunk[0])).find((m) => typeof m === "function"); - } + if (contextMenuChunk) { + const mod = require(contextMenuChunk[0]); + Spicetify.ReactComponent.ContextMenu = + Object.values(mod)?.[0]?.render ?? + Object.values(mod).find((m) => typeof m === "function"); + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
jsHelper/spicetifyWrapper.js(1 hunks)
Tested on .46, .64, .70, .71
Summary by CodeRabbit