Skip to content

Conversation

@KaiAF
Copy link
Contributor

@KaiAF KaiAF commented Sep 18, 2025

Now the "Pretty Lyrics" snippet works. I've tested a few extensions that modify the lyrics page and they appear to work now as well.

image

Summary by CodeRabbit

  • New Features
    • Improved support for lyrics display and interactivity, preparing the interface for enhanced styling.
  • Style
    • Expanded styling coverage for lyrics backgrounds, containers, and text states (active, highlight, interactive).
  • Chores
    • Added new CSS mappings; existing mappings remain unchanged.

@coderabbitai
Copy link

coderabbitai bot commented Sep 18, 2025

Walkthrough

Added 10 new hashed IDs to css-map.json, each mapping to existing lyrics-related CSS paths. No removals or modifications; the change is purely additive.

Changes

Cohort / File(s) Summary
CSS map updates
css-map.json
Added 10 new hashed IDs mapping to lyrics-related CSS keys: background, container, contentContainer, contentWrapper, lyricsContent-active, -highlight, -isInteractive, -lyric, -provider, -text. No existing mappings changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • rxri

Poem

A hop, a skip, a map refreshed—
Ten tiny hashes neatly meshed.
Lyrics paths aligned in tune,
CSS stars beneath the moon.
Thump-thump! I stamp my happy paw—
Additive change, no bug to gnaw. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately summarizes the primary change: adding missing lyrics classes to the css-map. It follows conventional commit style (feat(css-map):), is concise, and contains no extraneous information or vague wording. This aligns with the PR description and the additive changes to css-map.json, so a reviewer can quickly grasp the intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
css-map.json (1)

140-140: Optional: automate hash refresh for lyrics classes.

Consider a small fetch/compare script that diffs live client CSS class hashes and opens an automated PR to update these mappings; this avoids regressions when hashes rotate.

Happy to draft a script/CI job if useful.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e6d312 and 38eb20c.

📒 Files selected for processing (1)
  • css-map.json (1 hunks)
🔇 Additional comments (1)
css-map.json (1)

140-140: LGTM — lyrics hash additions verified.
JSON valid; all 10 new keys present; lyrics-lyrics mapping count = 37.

@rxri rxri merged commit 49da032 into spicetify:main Sep 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants