Move morgan login to server index.#2518
Merged
Merged
Conversation
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
Member
|
Travis is unhappy, @abuiles mind taking a look? |
Member
Author
|
Checking Adolfo Builes On Tue, Nov 18, 2014 at 9:03 AM, Robert Jackson notifications@github.com
|
Member
|
rerunning tests |
abuiles
force-pushed
the
move-morgan-to-index-js
branch
3 times, most recently
from
3a2d250 to
03edb1c
Compare
abuiles
force-pushed
the
move-morgan-to-index-js
branch
from
03edb1c to
18e35da
Compare
Member
Author
|
@rwjblue @stefanpenner this is finally green :). I added morgan when doing http-mock since it generates the index file too. |
stefanpenner
added a commit
that referenced
this pull request
Nov 19, 2014
Move morgan login to server index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stefanpenner I forgot about #2261 which was merged last night. I wanted to change it so we only use morgan in the index file, it might be redundant to use it for every proxy, also we might want it for mocks too.