fix(javadoc): partial isthmus calcite#755
Merged
bestbeforetoday merged 1 commit intosubstrait-io:mainfrom Mar 18, 2026
Merged
Conversation
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
mbwhite
force-pushed
the
fix-javadoc-c-002
branch
from
0a515da to
5788059
Compare
mbwhite
changed the title
bestbeforetoday
approved these changes
Mar 18, 2026
|
|
||
| /** Basic {@link AbstractTable} implementation */ | ||
| /** | ||
| * Basic {@link AbstractTable} implementation for Substrait. |
Member
There was a problem hiding this comment.
Just an observation—not necessary to change anything...
The existing JavaDoc says AbstractTable but I think in reality this is a org.apache.calcite.schema.Table implementation. The fact it extends AbstractTable (which in turn implements the Table interface is more an implementation convenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.