fix picture validation error on upload (#5078)

* fix picture validation error on upload

it wasn't using picture profile schema when
validating so it was missing info on extra fields.

SDANSA-564

* disable upload when loading schema

* fix lint

Author: petrjasek

package-lock.json

@@ -17,6 +17,7 @@ interface IScope extends ng.IScope {
     metadata: any;
     save: any;
     close: any;
+    schemaLoading: boolean;
     getSelectedImages(): Array<any>;
     saveHandler(images): Promise<void>;
     successHandler?(): void;
@@ -134,6 +135,18 @@ export function MultiImageEditController(
         getLabelForFieldId = _getLabelForFieldId;
     });
 
+    let schema = {};
+
+    $scope.schemaLoading = true;
+
+    content.getType('picture').then((pictureSchema) => {
+        schema = pictureSchema;
+    }, (error) => {
+        logger.warn('Failed to load picture schema', error);
+    }).finally(() => {
+        $scope.schemaLoading = false;
+    });
+
     $scope.save = (close) => {
         const imagesForSaving = angular.copy($scope.images);
 
@@ -146,7 +159,7 @@ export function MultiImageEditController(
                 validateMediaFieldsThrows(
                     $scope.validator,
                     metadata,
-                    content.schema({}, 'picture'),
+                    content.schema(schema, 'picture'),
                     getLabelForFieldId);
             });
         } catch (e) {

scripts/apps/search/MultiImageEdit.ts

@@ -14,7 +14,7 @@ <h3 class="modal__heading modal__heading--grow" translate>Upload media</h3>
     <div class="modal__header-buttons modal__header-buttons--right">
         <button class="btn btn--hollow" ng-click="close()" ng-disabled="uploadInProgress" translate>Cancel</button>
         <div ng-transclude="select-desk"></div>
-        <button class="btn btn--primary btn--hollow" ng-click="save(true)" ng-disabled="!images.length" translate data-test-id="multi-image-edit--start-upload">Upload</button>
+        <button class="btn btn--primary btn--hollow" ng-click="save(true)" ng-disabled="!images.length || schemaLoading === true" translate data-test-id="multi-image-edit--start-upload">Upload</button>
     </div>
 </div>