Fixed bugs in Path Control contextual click handling

Author: sveinbjornt

CHANGES.md

@@ -5,6 +5,7 @@
 ### 13/11/2025 - Version 3.4.1
 
 * New application icon
+* Fix path bar contextual menu handling
 * Minor UI and bug fixes
 * Some code modernization
 

TODO.md

@@ -2,7 +2,6 @@
 
 * Fix checking Regex and Case Insensitive in filter field options
 * Preserve selection between refreshes (preserve expanded items between refreshes?)
-* Fix path bar folders contextual click
 * Show full command (w/args) for process (ala ps -ef) in Info Panel
 * Highlight matching part of string when filtering (option in filter field popup)
 * Store authentication privileges and use them to run command line tool "/usr/bin/file" for Info Dialog

resources/Info.plist

@@ -23,7 +23,7 @@
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>361</string>
+	<string>362</string>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.utilities</string>
 	<key>LSMinimumSystemVersion</key>

source/Util/NSPathControl+ContextMenu.h

@@ -1,3 +1,34 @@
+/*
+    Copyright (c) 2018-2025, Sveinbjorn Thordarson <sveinbjorn@sveinbjorn.org>
+    All rights reserved.
+
+    Redistribution and use in source and binary forms, with or without modification,
+    are permitted provided that the following conditions are met:
+
+    1. Redistributions of source code must retain the above copyright notice, this
+    list of conditions and the following disclaimer.
+
+    2. Redistributions in binary form must reproduce the above copyright notice, this
+    list of conditions and the following disclaimer in the documentation and/or other
+    materials provided with the distribution.
+
+    3. Neither the name of the copyright holder nor the names of its contributors may
+    be used to endorse or promote products derived from this software without specific
+    prior written permission.
+
+    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+    ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+    WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+    IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
+    INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+    NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+    PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+    WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+    ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+    POSSIBILITY OF SUCH DAMAGE.
+*/
+
+
 #import <Cocoa/Cocoa.h>
 
 NS_ASSUME_NONNULL_BEGIN

source/Util/NSPathControl+ContextMenu.m

@@ -1,11 +1,43 @@
+/*
+    Copyright (c) 2018-2025, Sveinbjorn Thordarson <sveinbjorn@sveinbjorn.org>
+    All rights reserved.
+
+    Redistribution and use in source and binary forms, with or without modification,
+    are permitted provided that the following conditions are met:
+
+    1. Redistributions of source code must retain the above copyright notice, this
+    list of conditions and the following disclaimer.
+
+    2. Redistributions in binary form must reproduce the above copyright notice, this
+    list of conditions and the following disclaimer in the documentation and/or other
+    materials provided with the distribution.
+
+    3. Neither the name of the copyright holder nor the names of its contributors may
+    be used to endorse or promote products derived from this software without specific
+    prior written permission.
+
+    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+    ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+    WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+    IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
+    INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+    NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+    PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+    WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+    ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+    POSSIBILITY OF SUCH DAMAGE.
+*/
+
 #import "NSPathControl+ContextMenu.h"
 #import "NSWorkspace+Additions.h"
-#import "IconUtils.h"
+#import <objc/runtime.h>
+
+static const char * kFilePathAssociatedObjectKey = "filePath";
 
 @implementation NSPathControl (ContextMenu)
 
+// Generate contextual menu for a Ctrl-clicked item in the Path Control
 - (NSMenu *)menuForEvent:(NSEvent *)event {
-    
     NSPoint point = [self convertPoint:[event locationInWindow] fromView:nil];
     NSRect frame = [self bounds];
     NSPathCell *cell = (NSPathCell *)[self cell];
@@ -23,7 +55,7 @@ - (NSMenu *)menuForEvent:(NSEvent *)event {
 
     NSMenu *menu = [[NSMenu alloc] initWithTitle:@""];
 
-    // Open
+    // Open (with default app)
     NSMenuItem *openItem = [[NSMenuItem alloc] initWithTitle:@"Open" action:@selector(openPath:) keyEquivalent:@""];
     [openItem setTarget:self];
     [openItem setRepresentedObject:path];
@@ -38,11 +70,15 @@ - (NSMenu *)menuForEvent:(NSEvent *)event {
     }
     [menu addItem:openItem];
 
-    // Open With
+    // Open With submenu
     NSMenuItem *openWithItem = [[NSMenuItem alloc] initWithTitle:@"Open With" action:nil keyEquivalent:@""];
     NSMenu *openWithMenu = [[NSMenu alloc] init];
+    objc_setAssociatedObject(openWithMenu, kFilePathAssociatedObjectKey, path, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
     [openWithItem setSubmenu:openWithMenu];
-    [[NSWorkspace sharedWorkspace] openWithMenuForFile:path target:self action:@selector(openPathWithApplication:) menu:openWithMenu];
+    [[NSWorkspace sharedWorkspace] openWithMenuForFile:path
+                                                target:self
+                                                action:@selector(openPathWithApplication:)
+                                                  menu:openWithMenu];
     [menu addItem:openWithItem];
 
     [menu addItem:[NSMenuItem separatorItem]];
@@ -53,12 +89,13 @@ - (NSMenu *)menuForEvent:(NSEvent *)event {
     [showItem setRepresentedObject:path];
     [menu addItem:showItem];
 
-    // Get Info
-    NSMenuItem *getInfoItem = [[NSMenuItem alloc] initWithTitle:@"Get Info" action:@selector(showPathInfoInFinder:) keyEquivalent:@""];
+    // Get Info in Finder
+    NSMenuItem *getInfoItem = [[NSMenuItem alloc] initWithTitle:@"Show Info in Finder" action:@selector(showPathInfoInFinder:) keyEquivalent:@""];
     [getInfoItem setTarget:self];
     [getInfoItem setRepresentedObject:path];
     [menu addItem:getInfoItem];
 
+    // Separator
     [menu addItem:[NSMenuItem separatorItem]];
 
     // Copy Path
@@ -78,8 +115,8 @@ - (void)openPath:(id)sender {
 }
 
 - (void)openPathWithApplication:(id)sender {
-    NSString *appPath = [sender representedObject];
-    NSString *filePath = [[[sender menu] supermenu] representedObject];
+    NSString *appPath = [sender toolTip];
+    NSString *filePath = objc_getAssociatedObject([sender menu], kFilePathAssociatedObjectKey);
     [[NSWorkspace sharedWorkspace] openFile:filePath withApplication:appPath];
 }