Conversation
c3541a3 to
10f28a8
Compare
|
Re Travis: I'm not sure how much luck we'll have getting LLVM/clang 6 on Ubuntu Trusty – if necessary, we can make a docker container with everything we need and Travis can build SVF inside it. |
|
Jack, Very good! Thanks a lot for your contribution! I will take a look at the patch next week. It seems no significant changes made compared to 5.0. By the way, you can also try PTABen (https://github.com/SVF-tools/PTABen) to validate the correctness (e.g., basic_c_tests). Simply copy the benchmark suite under SVF and execute "runtest.sh". @mbarbar Could you please help Jack to set up the travis? Thanks, |
yuleisui
left a comment
There was a problem hiding this comment.
Jack,
The whole patch looks good to me. It has passed all micro-benchmarks.
I will merge it soon.
|
Great, cheers Yulei! |
Relevant LLVM changes for updating to v6.0.0 from v4.0.0:
IsPostDominatorsmember ofllvm::DominanceFrontierBasehas become a template parameter (https://reviews.llvm.org/D35315).llvm::Function::getArgumentListhas been dropped in favour ofllvm::Function::arg_begin,llvm::Function::arg_endandllvm::Function::args(https://reviews.llvm.org/rL298010).tool_output_filehas been renamedToolOutputFile.FindAllocaDbgDeclarehas been replaced withFindDbgAddrUses, which returns a list of zero or onellvm.dbg.declareintrinsics plus zero or morellvm.dbg.addrintrinsics (upcast asDbgInfoIntrinsicobjects) (https://reviews.llvm.org/D37768).I've run the test script for the
mem_leakdirectory and it all looks fine – could you advise any further testing that needs to be done?Many thanks!
Jack