Add tests for optional authentication_type and fix argparse defaults

- Remove unnecessary default=None from argparse arguments (implicit for optional args)
- Add test_update_connections_without_auth_type for datasources
- Add test_update_workbook_connections_without_auth_type for workbooks
- Tests verify that auth_type is preserved from server response when not specified

These tests ensure the optional authentication_type parameter works correctly
and that existing authentication types are preserved when updating only
credentials without changing auth type.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: 2 people

samples/update_connections_auth.py

@@ -22,9 +22,9 @@ def main():
     # Resource-specific
     parser.add_argument("resource_type", choices=["workbook", "datasource"])
     parser.add_argument("resource_id")
-    parser.add_argument("--datasource_username", default=None, help="Datasource username (optional)")
-    parser.add_argument("--authentication_type", default=None, help="Authentication type (optional)")
-    parser.add_argument("--datasource_password", default=None, help="Datasource password (optional)")
+    parser.add_argument("--datasource_username", help="Datasource username (optional)")
+    parser.add_argument("--authentication_type", help="Authentication type (optional)")
+    parser.add_argument("--datasource_password", help="Datasource password (optional)")
     parser.add_argument(
         "--embed_password", default="true", choices=["true", "false"], help="Embed password (default: true)"
     )

test/test_datasource.py

@@ -277,6 +277,44 @@ def test_update_connections(server) -> None:
         assert "auth-keypair" == connection_items[0].auth_type
 
 
+def test_update_connections_without_auth_type(server) -> None:
+    """Test that update_connections works when authentication_type is not provided."""
+    populate_xml = POPULATE_CONNECTIONS_XML.read_text()
+    response_xml = UPDATE_CONNECTIONS_NO_AUTH_XML.read_text()
+
+    with requests_mock.Mocker() as m:
+
+        datasource_id = "9dbd2263-16b5-46e1-9c43-a76bb8ab65fb"
+        connection_luids = ["be786ae0-d2bf-4a4b-9b34-e2de8d2d4488", "a1b2c3d4-e5f6-7a8b-9c0d-123456789abc"]
+
+        datasource = TSC.DatasourceItem(datasource_id)
+        datasource._id = "9dbd2263-16b5-46e1-9c43-a76bb8ab65fb"
+        datasource.owner_id = "dd2239f6-ddf1-4107-981a-4cf94e415794"
+        server.version = "3.26"
+
+        m.get(
+            "http://test/api/3.26/sites/dad65087-b08b-4603-af4e-2887b8aafc67/datasources/9dbd2263-16b5-46e1-9c43-a76bb8ab65fb/connections",
+            text=populate_xml,
+        )
+        m.put(
+            "http://test/api/3.26/sites/dad65087-b08b-4603-af4e-2887b8aafc67/datasources/9dbd2263-16b5-46e1-9c43-a76bb8ab65fb/connections",
+            text=response_xml,
+        )
+
+        # Update connections without specifying authentication_type
+        connection_items = server.datasources.update_connections(
+            datasource_item=datasource,
+            connection_luids=connection_luids,
+            username="user1",
+            embed_password=True,
+        )
+        updated_ids = [conn.id for conn in connection_items]
+
+        assert updated_ids == connection_luids
+        # Verify that the auth type from the response is preserved (UsernamePassword)
+        assert connection_items[0].auth_type == "UsernamePassword"
+
+
 def test_populate_permissions(server) -> None:
     response_xml = POPULATE_PERMISSIONS_XML.read_text()
     with requests_mock.mock() as m:

test/test_workbook.py

@@ -1048,6 +1048,42 @@ def test_update_workbook_connections(server: TSC.Server) -> None:
         assert "AD Service Principal" == connection_items[0].auth_type
 
 
+def test_update_workbook_connections_without_auth_type(server: TSC.Server) -> None:
+    """Test that update_connections works when authentication_type is not provided."""
+    populate_xml = POPULATE_CONNECTIONS_XML.read_text()
+    response_xml = UPDATE_CONNECTIONS_NO_AUTH_XML.read_text()
+
+    with requests_mock.Mocker() as m:
+        workbook_id = "1a2b3c4d-5e6f-7a8b-9c0d-112233445566"
+        connection_luids = ["abc12345-def6-7890-gh12-ijklmnopqrst", "1234abcd-5678-efgh-ijkl-0987654321mn"]
+
+        workbook = TSC.WorkbookItem(workbook_id)
+        workbook._id = workbook_id
+        server.version = "3.26"
+        url = f"{server.baseurl}/{workbook_id}/connections"
+        m.get(
+            "http://test/api/3.26/sites/dad65087-b08b-4603-af4e-2887b8aafc67/workbooks/1a2b3c4d-5e6f-7a8b-9c0d-112233445566/connections",
+            text=populate_xml,
+        )
+        m.put(
+            "http://test/api/3.26/sites/dad65087-b08b-4603-af4e-2887b8aafc67/workbooks/1a2b3c4d-5e6f-7a8b-9c0d-112233445566/connections",
+            text=response_xml,
+        )
+
+        # Update connections without specifying authentication_type
+        connection_items = server.workbooks.update_connections(
+            workbook_item=workbook,
+            connection_luids=connection_luids,
+            username="user1",
+            embed_password=True,
+        )
+        updated_ids = [conn.id for conn in connection_items]
+
+        assert updated_ids == connection_luids
+        # Verify that the auth type from the response is preserved (UsernamePassword)
+        assert connection_items[0].auth_type == "UsernamePassword"
+
+
 def test_get_workbook_all_fields(server: TSC.Server) -> None:
     server.version = "3.21"
     baseurl = server.workbooks.baseurl