Address reviewer feedback from jorwoods

- Remove unnecessary default=None from argparse optional arguments
- Remove unused imports (read_xml_asset, read_xml_assets) from test files
- Use Path.read_text() directly instead of helper functions
- Keep only 'asset' import for other uses in test files

These changes improve code clarity and follow Python best practices.

Author: vchavatapalli

samples/update_connections_auth.py

@@ -22,9 +22,9 @@ def main():
     # Resource-specific
     parser.add_argument("resource_type", choices=["workbook", "datasource"])
     parser.add_argument("resource_id")
-    parser.add_argument("--datasource_username", default=None, help="Datasource username (optional)")
-    parser.add_argument("--authentication_type", default=None, help="Authentication type (optional)")
-    parser.add_argument("--datasource_password", default=None, help="Datasource password (optional)")
+    parser.add_argument("--datasource_username", help="Datasource username (optional)")
+    parser.add_argument("--authentication_type", help="Authentication type (optional)")
+    parser.add_argument("--datasource_password", help="Datasource password (optional)")
     parser.add_argument(
         "--embed_password", default="true", choices=["true", "false"], help="Embed password (default: true)"
     )

test/test_datasource.py

@@ -16,7 +16,7 @@
 from tableauserverclient.server.endpoint.exceptions import InternalServerError
 from tableauserverclient.server.endpoint.fileuploads_endpoint import Fileuploads
 from tableauserverclient.server.request_factory import RequestFactory
-from ._utils import asset, read_xml_asset, read_xml_assets
+from ._utils import asset
 
 TEST_ASSET_DIR = Path(__file__).parent / "assets"
 
@@ -162,7 +162,8 @@ def test_update_copy_fields(server) -> None:
     assert single_datasource._project_name == updated_datasource._project_name
 
     def test_update_connections(self) -> None:
-        populate_xml, response_xml = read_xml_assets(POPULATE_CONNECTIONS_XML, UPDATE_CONNECTIONS_XML)
+        populate_xml = POPULATE_CONNECTIONS_XML.read_text()
+        response_xml = UPDATE_CONNECTIONS_XML.read_text()
 
         with requests_mock.Mocker() as m:
 
@@ -201,7 +202,8 @@ def test_update_connections(self) -> None:
 
     def test_update_connections_without_auth_type(self) -> None:
         """Test that update_connections works when authentication_type is not provided."""
-        populate_xml, response_xml = read_xml_assets(POPULATE_CONNECTIONS_XML, UPDATE_CONNECTIONS_NO_AUTH_XML)
+        populate_xml = POPULATE_CONNECTIONS_XML.read_text()
+        response_xml = UPDATE_CONNECTIONS_NO_AUTH_XML.read_text()
 
         with requests_mock.Mocker() as m:
 

test/test_workbook.py

@@ -13,7 +13,6 @@
 from tableauserverclient.models import UserItem, GroupItem, PermissionsRule
 from tableauserverclient.server.endpoint.exceptions import InternalServerError, UnsupportedAttributeError
 from tableauserverclient.server.request_factory import RequestFactory
-from ._utils import asset, read_xml_asset, read_xml_assets
 
 TEST_ASSET_DIR = Path(__file__).parent / "assets"
 
@@ -709,7 +708,8 @@ def test_publish_with_thumbnails_user_id(server: TSC.Server) -> None:
         assert re.search(b'thumbnailsUserId=\\"ee8c6e70-43b6-11e6-af4f-f7b0d8e20761\\"', request_body)
 
     def test_update_workbook_connections(self) -> None:
-        populate_xml, response_xml = read_xml_assets(POPULATE_CONNECTIONS_XML, UPDATE_CONNECTIONS_XML)
+        populate_xml = POPULATE_CONNECTIONS_XML.read_text()
+        response_xml = UPDATE_CONNECTIONS_XML.read_text()
 
         with requests_mock.Mocker() as m:
             workbook_id = "1a2b3c4d-5e6f-7a8b-9c0d-112233445566"
@@ -742,7 +742,8 @@ def test_update_workbook_connections(self) -> None:
 
     def test_update_workbook_connections_without_auth_type(self) -> None:
         """Test that update_connections works when authentication_type is not provided."""
-        populate_xml, response_xml = read_xml_assets(POPULATE_CONNECTIONS_XML, UPDATE_CONNECTIONS_NO_AUTH_XML)
+        populate_xml = POPULATE_CONNECTIONS_XML.read_text()
+        response_xml = UPDATE_CONNECTIONS_NO_AUTH_XML.read_text()
 
         with requests_mock.Mocker() as m:
             workbook_id = "1a2b3c4d-5e6f-7a8b-9c0d-112233445566"