build: consolidate tsconfig#138
Merged
Merged
Conversation
I think given that the project is all ESM it seems fine to consolidate down to one tsconfig. I ran the build with this config and the previous config and diffed the files outputted to dist and they are identical. No worries if you don't want to merge after the recent churn/issues. I looked at the docs for each of the changes I made, there are no issues reported by and the tests still pass.
techniq
approved these changes
May 13, 2025
Owner
techniq
left a comment
techniq
left a comment
There was a problem hiding this comment.
I was already having the same thought (I'm all for simplicity) and I don't for see adding CommonJS support back (you can continue to use 7.x if needed). Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think given that the project is all ESM it seems fine to consolidate down to one tsconfig. I ran the build with this config and the previous config and diffed the files outputted to dist and they are identical. No worries if you don't want to merge after the recent churn/issues. I looked at the docs for each of the changes I made, there are no issues reported by
tacand the tests still pass. These changes might potentially make the TS upgrade smoother if this project ever updates to typescript@5.Before I discovered the issue with the script ordering I was seeing if these changes would resolve the issue with the d.ts files not being included when publishing.