How to disable test.require stage

[LecrisUT]

If necessary through tmt run that would work as well

[lukaszachy]

You mean stop tmt run to install require/recommend during 'prepare' step? Not possible ATM :(

But shouldn't be that hard to implement

[happz]

Hmm, good point... I'm afraid adjust won't work here, because adjust applies when tmt loads fmf files, then adjust is evaluated, then tmt gets the resulting tree & converts it into internal objects like tests and stories, and way later, tmt adds a specially constructed install phase into prepare step to install stuff. This happens so late after adjust that it has no chance of affecting this. When adjust happens, this special phase does not exist, because it's not written in fmf files.

[LecrisUT]

I was thinking that there is an even more fundamental issue that prepare can be an array, at which point we cannot add a top-level key-value and keep it yaml parseable. But I guess adjust would be able to overcome this?

As for the order, couldn't the skip_require field be checked right before injecting the install.require?

[happz]

I was thinking that there is an even more fundamental issue that prepare can be an array, at which point we cannot add a top-level key-value and keep it yaml parseable.

Correct, but that could be solved by adding "special" plugin representing this operation, which would own these options and which one would be able to disable. It'd be equivalent to prepare --how special --skip-require --skip-recommend.

adjust should work in this case as well, are we heading towards something like this? @psss @lukaszachy WDYT?

prepare:
  - how: install
    packages:
      - foo

  - how: ansible
    playbook /foo.yaml

  # the special one, represents the phase added by `prepare`
  - how: requires
    skip-require: true
    skip-recommend: false

    adjust:
      when: distro == rhel-9
      enabled: true

[lukaszachy]

At the moment adjust is a plan level key, so above example can't work. What could work (with current adjust) is

adjust:
  when: distro != rhel-9 
  prepare+:
     - how: requires
       skip-require: true

But having adjust closer to the step phase would be really nice to have.

[lukaszachy]

Another thought though: Karel had rfe to install require before each test so isn't it more 'run' property and the fact it happens in prepare plugin is just an implementation detail? So something like tmt run --skip-install-require or tmt run --install [prepare|execute|never] ?

We can create place to store such option in the plan.fmf somehow (and be subject of adjust)