fix: address hidden steep issues (#415)

* otel regression test

* fix: address hidden steep issues

* test: place steep ignore on block pass

Author: chris-olszewski

temporalio/Steepfile

@@ -15,7 +15,7 @@ target :lib do
   signature 'sig'
   check 'lib'
   ignore 'lib/temporalio/api', 'lib/temporalio/internal/bridge/api'
-  library 'uri', 'objspace'
+  library 'uri', 'objspace', 'etc'
   configure_code_diagnostics do |hash|
     hash.update(common_diagnostics)
   end
@@ -24,7 +24,7 @@ end
 target :test do
   signature 'sig', 'test/sig'
   check 'test'
-  library 'uri', 'objspace'
+  library 'uri', 'objspace', 'etc'
   configure_code_diagnostics do |hash|
     hash.update(common_diagnostics)
     # Steep cannot infer some things, so we can ignore them in tests

temporalio/lib/temporalio/client.rb

@@ -216,7 +216,7 @@ def self._validate_plugins!(plugins)
     def initialize(
       connection:,
       namespace:,
-      data_converter: DataConverter.default,
+      data_converter: Converters::DataConverter.default,
       plugins: [],
       interceptors: [],
       logger: Logger.new($stdout, level: Logger::WARN),

temporalio/lib/temporalio/contrib/open_telemetry.rb

@@ -158,15 +158,15 @@ def start_update_with_start_workflow(input)
           # @!visibility private
           def signal_with_start_workflow(input)
             @root._with_started_span(
-              name: "SignalWithStartWorkflow:#{input.workflow}",
+              name: "SignalWithStartWorkflow:#{input.start_workflow_operation.options.workflow}",
               kind: :client,
-              attributes: { 'temporalWorkflowID' => input.start_workflow_operation.options.id },
-              outbound_input: input
+              attributes: { 'temporalWorkflowID' => input.start_workflow_operation.options.id }
             ) do
-              # Also add to start headers
-              if input.headers[@header_key]
-                input.start_workflow_operation.options.headers[@header_key] = input.headers[@header_key]
-              end
+              # SignalWithStartWorkflowInput has no top-level headers field and instead uses
+              # start_workflow_operation.options.headers.
+              # So tracing context must be injected explicitly instead of relying
+              # on _with_started_span.
+              @root._apply_context_to_headers(input.start_workflow_operation.options.headers)
               super
             end
           end

temporalio/sig/open_telemetry.rbs

@@ -0,0 +1,47 @@
+module OpenTelemetry
+  module Context
+    def self.current: -> untyped
+    def self.attach: (untyped context) -> untyped
+    def self.detach: (untyped token) -> void
+
+    module Propagation
+      class CompositeTextMapPropagator
+        def self.compose_propagators: (Array[untyped] propagators) -> untyped
+      end
+    end
+  end
+
+  module Baggage
+    module Propagation
+      class TextMapPropagator
+        def initialize: -> void
+      end
+    end
+  end
+
+  module Trace
+    def self.with_span: [T] (untyped span) { -> T } -> T
+    def self.current_span: (?untyped context) -> untyped
+    def self.context_with_span: (untyped span) -> untyped
+
+    class Link
+      def initialize: (untyped context) -> void
+    end
+
+    module Status
+      def self.error: (String description) -> untyped
+    end
+
+    module Propagation
+      module TraceContext
+        class TextMapPropagator
+          def initialize: -> void
+        end
+      end
+    end
+
+    class Span
+      INVALID: untyped
+    end
+  end
+end

temporalio/sig/temporalio/contrib/open_telemetry.rbs

@@ -27,6 +27,14 @@ module Temporalio
         ) { () -> T } -> T
         def _always_create_workflow_spans: -> bool
 
+        class ClientOutbound < Client::Interceptor::Outbound
+          def initialize: (TracingInterceptor root, Client::Interceptor::Outbound next_interceptor) -> void
+        end
+
+        class ActivityInbound < Worker::Interceptor::Activity::Inbound
+          def initialize: (TracingInterceptor root, Worker::Interceptor::Activity::Inbound next_interceptor) -> void
+        end
+
         class WorkflowInbound < Worker::Interceptor::Workflow::Inbound
           def initialize: (TracingInterceptor root, Worker::Interceptor::Workflow::Inbound next_interceptor) -> void
 

temporalio/sig/temporalio/converters/payload_converter/binary_null.rbs

@@ -2,7 +2,8 @@ module Temporalio
   module Converters
     class PayloadConverter
       class BinaryNull < Encoding
+        ENCODING: String
       end
     end
   end
-end
+end

temporalio/sig/temporalio/converters/payload_converter/binary_plain.rbs

@@ -2,7 +2,8 @@ module Temporalio
   module Converters
     class PayloadConverter
       class BinaryPlain < Encoding
+        ENCODING: String
       end
     end
   end
-end
+end

temporalio/sig/temporalio/converters/payload_converter/binary_protobuf.rbs

@@ -2,7 +2,8 @@ module Temporalio
   module Converters
     class PayloadConverter
       class BinaryProtobuf < Encoding
+        ENCODING: String
       end
     end
   end
-end
+end

temporalio/sig/temporalio/converters/payload_converter/json_plain.rbs

@@ -1,12 +1,14 @@
 module Temporalio
   module Converters
     class PayloadConverter
-      class JsonPlain < Encoding
+      class JSONPlain < Encoding
+        ENCODING: String
+
         def initialize: (
-          ?Hash[Symbol, untyped] parse_options,
-          ?Hash[Symbol, untyped] generate_options
+          ?parse_options: Hash[Symbol, untyped],
+          ?generate_options: Hash[Symbol, untyped]
         ) -> void
       end
     end
   end
-end
+end

temporalio/sig/temporalio/converters/payload_converter/json_protobuf.rbs

@@ -1,8 +1,9 @@
 module Temporalio
   module Converters
     class PayloadConverter
-      class JsonProtobuf < Encoding
+      class JSONProtobuf < Encoding
+        ENCODING: String
       end
     end
   end
-end
+end