This repository was archived by the owner on Jul 31, 2025. It is now read-only.
Allow scripting the terminal in TUF commands#1155
Merged
Merged
Conversation
Signed-off-by: Evan Cordell <cordell.evan@gmail.com>
cyli
approved these changes
May 9, 2017
cyli
left a comment
cyli
left a comment
Contributor
There was a problem hiding this comment.
Hm... I don't really remember why either, although I have a hazy memory that we decided if not in a terminal we can use env vars. I don't know if I am just making this up after the fact though.
This LGTM, thanks for fixing.
ping @endophage and @riyazdf to see if their memory is better than mine :)
Contributor
Author
|
Can you use ENV vars for setting username/password and not just key passphrases? |
Contributor
|
@ecordell Ah blah, sorry, you're right the auth info cannot be set via ENV vars. |
Contributor
|
jenkins failure looks unrelated, kicking off tests again now |
endophage
approved these changes
May 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change came in here: 25cd29c
But I can't really tell why. It breaks scripting tuf commands (if you're not running in a terminal, all requests are anonymous to the server).
I think #861 is the proper solution, but for now it's nice to be able to script it via stdin.