Drop support for RSA key generation#1191
Conversation
umayr
force-pushed
the
feat/no-rsa-key-generate
branch
from
5d1301d to
0501284
Compare
|
Is there any timeline for when RSA support will be dropped? |
umayr
changed the title
|
@dingwilson we have no intent to drop support for using externally provided RSA keys. We are only ending support for internally generating RSA keys. |
| require.NoError(t, err, "error creating repo: %s", err) | ||
|
|
||
| rootPubKey, err := repo.CryptoService.Create(data.CanonicalRootRole, repo.gun, rootType) | ||
| rootPubKey, err := testutils.CreateOrAddKey(repo.CryptoService, data.CanonicalRootRole, repo.gun, rootType) |
There was a problem hiding this comment.
what's the rationale for using the testutil instead of the direct cryptoservice call?
There was a problem hiding this comment.
ah of course – because the cryptoservice cannot create RSA keys? If that is the exact reason, this is perfectly fine then.
There was a problem hiding this comment.
@riyazdf Exactly.
To add more on this, I tried to add keys to crypto service in case of RSA, while for other sort of keys I created them with crypto service which later adds them internally.
riyazdf
left a comment
riyazdf
left a comment
There was a problem hiding this comment.
needs a rebase but code otherwise LGTM
umayr
force-pushed
the
feat/no-rsa-key-generate
branch
from
0501284 to
35c3062
Compare
|
@riyazdf Rebased and fixed the conflicts. Let me know if there's anything else. |
Signed-off-by: Umayr Shahid <umayr.shahid@gmail.com>
umayr
force-pushed
the
feat/no-rsa-key-generate
branch
from
35c3062 to
bc13ee7
Compare
|
@endophage I have added an explicit error message that tells rsa key generation is not supported, I have also added a negative case that verifies this moreover, I have rebased it with latest origin/master. Please let me know if it requires anything else. |
4 participants
After this change notary won't be able to generate RSA keys, although it can import and parse keys if provided externally.
CC: @endophage