Skip to content
This repository was archived by the owner on Jul 31, 2025. It is now read-only.

Be consistent about Notary vs notary#1324

Merged
cyli merged 1 commit into
notaryproject:masterfrom
amouat:patch-1
Apr 3, 2018
Merged

Be consistent about Notary vs notary#1324
cyli merged 1 commit into
notaryproject:masterfrom
amouat:patch-1

Conversation

@amouat

@amouat amouat commented Mar 30, 2018

Copy link
Copy Markdown
Contributor

Sorry, a bit OCD but it was getting to me :)

@GordonTheTurtle

Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:amouat/notary.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@docker-jenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

Sorry, a bit OCD but it was getting to me :)

Signed-off-by: Adrian Mouat <adrian.mouat@gmail.com>
@HuKeping

HuKeping commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

seems great :)

@cyli

cyli commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

jenkins, test this please

@cyli cyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @amouat - LGTM pending CI

@ecordell ecordell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyli cyli merged commit 107dd1e into notaryproject:master Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants