Skip to content

Commit 0a86dfb

Browse files
authored
fix(types): remove duplicated definition of BucketOptions and make sure proper version is exported (googleapis#1583)
1 parent 5ef9fbc commit 0a86dfb

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

handwritten/storage/src/bucket.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ import {
5454
Cors,
5555
PreconditionOptions,
5656
IdempotencyStrategy,
57+
BucketOptions,
5758
} from './storage';
5859
import {
5960
GetSignedUrlResponse,
@@ -77,11 +78,6 @@ interface MetadataOptions {
7778
userProject?: string;
7879
}
7980

80-
interface BucketOptions {
81-
userProject?: string;
82-
preconditionOpts?: PreconditionOptions;
83-
}
84-
8581
export type GetFilesResponse = [File[], {}, Metadata];
8682
export interface GetFilesCallback {
8783
(

handwritten/storage/src/storage.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ export interface StorageOptions extends ServiceOptions {
9191
export interface BucketOptions {
9292
kmsKeyName?: string;
9393
userProject?: string;
94+
preconditionOpts?: PreconditionOptions;
9495
}
9596

9697
export interface Cors {

0 commit comments

Comments
 (0)