Skip to content

Commit a56f349

Browse files
TimothyMakkisonTimothyMakkison
committed
perf: use shared Task.FromResult(Passed) 
1 parent 6fe942e commit a56f349

30 files changed

Lines changed: 113 additions & 111 deletions

‎TUnit.Assertions/Assertions/Enums/EnumAssertions.cs‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
3535

3636
if (enumValue.HasFlag(enumFlag))
3737
{
38-
return Task.FromResult(AssertionResult.Passed);
38+
return AssertionResult._passedTask;
3939
}
4040

4141
return Task.FromResult(AssertionResult.Failed($"value {value} does not have flag {_expectedFlag}"));
@@ -75,7 +75,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
7575

7676
if (!enumValue.HasFlag(enumFlag))
7777
{
78-
return Task.FromResult(AssertionResult.Passed);
78+
return AssertionResult._passedTask;
7979
}
8080

8181
return Task.FromResult(AssertionResult.Failed($"value {value} has flag {_unexpectedFlag}"));
@@ -112,7 +112,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
112112
if (Enum.IsDefined(typeof(TEnum), value))
113113
#endif
114114
{
115-
return Task.FromResult(AssertionResult.Passed);
115+
return AssertionResult._passedTask;
116116
}
117117

118118
return Task.FromResult(AssertionResult.Failed($"value {value} is not defined in {typeof(TEnum).Name}"));
@@ -149,7 +149,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
149149
if (!Enum.IsDefined(typeof(TEnum), value))
150150
#endif
151151
{
152-
return Task.FromResult(AssertionResult.Passed);
152+
return AssertionResult._passedTask;
153153
}
154154

155155
return Task.FromResult(AssertionResult.Failed($"value {value} is defined in {typeof(TEnum).Name}"));
@@ -189,7 +189,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
189189

190190
if (valueName == otherName)
191191
{
192-
return Task.FromResult(AssertionResult.Passed);
192+
return AssertionResult._passedTask;
193193
}
194194

195195
return Task.FromResult(AssertionResult.Failed($"value name \"{valueName}\" does not equal \"{otherName}\""));
@@ -230,7 +230,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
230230

231231
if (valueAsInt == otherAsInt)
232232
{
233-
return Task.FromResult(AssertionResult.Passed);
233+
return AssertionResult._passedTask;
234234
}
235235

236236
return Task.FromResult(AssertionResult.Failed($"value {valueAsInt} does not equal {otherAsInt}"));
@@ -270,7 +270,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
270270

271271
if (valueName != otherName)
272272
{
273-
return Task.FromResult(AssertionResult.Passed);
273+
return AssertionResult._passedTask;
274274
}
275275

276276
return Task.FromResult(AssertionResult.Failed($"value name \"{valueName}\" equals \"{otherName}\""));
@@ -310,7 +310,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
310310

311311
if (valueAsInt != otherAsInt)
312312
{
313-
return Task.FromResult(AssertionResult.Passed);
313+
return AssertionResult._passedTask;
314314
}
315315

316316
return Task.FromResult(AssertionResult.Failed($"value {valueAsInt} equals {otherAsInt}"));

‎TUnit.Assertions/Assertions/Regex/MatchIndexAssertion.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<RegexMatc
5252
}
5353

5454
// If we have a match, the assertion passed
55-
return Task.FromResult(AssertionResult.Passed);
55+
return AssertionResult._passedTask;
5656
}
5757

5858
protected override string GetExpectation() => $"match at index {_index} to exist";

‎TUnit.Assertions/Assertions/Strings/ParseAssertions.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<string> m
4747

4848
if (TryParse(value, _formatProvider, out _))
4949
{
50-
return Task.FromResult(AssertionResult.Passed);
50+
return AssertionResult._passedTask;
5151
}
5252

5353
return Task.FromResult(AssertionResult.Failed($"\"{value}\" cannot be parsed into {typeof(T).Name}"));
@@ -146,12 +146,12 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<string> m
146146

147147
if (value == null)
148148
{
149-
return Task.FromResult(AssertionResult.Passed); // null cannot be parsed
149+
return AssertionResult._passedTask; // null cannot be parsed
150150
}
151151

152152
if (!TryParse(value, _formatProvider, out _))
153153
{
154-
return Task.FromResult(AssertionResult.Passed);
154+
return AssertionResult._passedTask;
155155
}
156156

157157
return Task.FromResult(AssertionResult.Failed($"\"{value}\" can be parsed into {typeof(T).Name}"));
@@ -330,7 +330,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<T> metada
330330
return Task.FromResult(AssertionResult.Failed($"parsing failed: {exception.Message}"));
331331
}
332332

333-
return Task.FromResult(AssertionResult.Passed);
333+
return AssertionResult._passedTask;
334334
}
335335

336336
protected override string GetExpectation() => $"to be parsable into {typeof(T).Name}";

‎TUnit.Assertions/Collections/MemoryAssertions.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TMemory>
565565

566566
if (passed)
567567
{
568-
return Task.FromResult(AssertionResult.Passed);
568+
return AssertionResult._passedTask;
569569
}
570570

571571
return Task.FromResult(AssertionResult.Failed($"found {actualCount}"));

‎TUnit.Assertions/Conditions/BetweenAssertion.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TValue> m
8989

9090
if (minOk && maxOk)
9191
{
92-
return Task.FromResult(AssertionResult.Passed);
92+
return AssertionResult._passedTask;
9393
}
9494

9595
return Task.FromResult(AssertionResult.Failed($"found {value}"));

‎TUnit.Assertions/Conditions/CollectionAssertions.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -702,7 +702,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TCollecti
702702

703703
if (enumerated.SequenceEqual(ordered))
704704
{
705-
return Task.FromResult(AssertionResult.Passed);
705+
return AssertionResult._passedTask;
706706
}
707707

708708
for (int i = 1; i < enumerated.Length; i++)
@@ -716,7 +716,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TCollecti
716716
}
717717
}
718718

719-
return Task.FromResult(AssertionResult.Passed);
719+
return AssertionResult._passedTask;
720720
}
721721

722722
protected override string GetExpectation() => "to be ordered by key selector in ascending order";
@@ -764,7 +764,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TCollecti
764764

765765
if (enumerated.SequenceEqual(ordered))
766766
{
767-
return Task.FromResult(AssertionResult.Passed);
767+
return AssertionResult._passedTask;
768768
}
769769

770770
for (int i = 1; i < enumerated.Length; i++)
@@ -778,7 +778,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TCollecti
778778
}
779779
}
780780

781-
return Task.FromResult(AssertionResult.Passed);
781+
return AssertionResult._passedTask;
782782
}
783783

784784
protected override string GetExpectation() => "to be ordered by key selector in descending order";

‎TUnit.Assertions/Conditions/CollectionNullAssertion.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TCollecti
2222

2323
if (value != null)
2424
{
25-
return Task.FromResult(AssertionResult.Passed);
25+
return AssertionResult._passedTask;
2626
}
2727

2828
return Task.FromResult(AssertionResult.Failed("value is null"));

‎TUnit.Assertions/Conditions/DateTimeSpecializedAssertions.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<DateTime>
2121
{
2222
if (metadata.Value == _expected)
2323
{
24-
return Task.FromResult(AssertionResult.Passed);
24+
return AssertionResult._passedTask;
2525
}
2626

2727
return Task.FromResult(AssertionResult.Failed(

‎TUnit.Assertions/Conditions/DictionaryAssertions.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TDictiona
6767

6868
if (found)
6969
{
70-
return Task.FromResult(AssertionResult.Passed);
70+
return AssertionResult._passedTask;
7171
}
7272

7373
return Task.FromResult(AssertionResult.Failed($"key {_expectedKey} not found"));
@@ -112,7 +112,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TDictiona
112112

113113
if (!value.ContainsKey(_expectedKey))
114114
{
115-
return Task.FromResult(AssertionResult.Passed);
115+
return AssertionResult._passedTask;
116116
}
117117

118118
return Task.FromResult(AssertionResult.Failed($"key {_expectedKey} was found"));

‎TUnit.Assertions/Conditions/EqualsAssertion.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TValue> m
8989
var result = DeepEquals(value, _expected, _ignoredTypes, visited);
9090
if (result.IsSuccess)
9191
{
92-
return Task.FromResult(AssertionResult.Passed);
92+
return AssertionResult._passedTask;
9393
}
9494

9595
return Task.FromResult(AssertionResult.Failed(result.Message ?? $"found {value}"));
@@ -100,7 +100,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TValue> m
100100

101101
if (comparer.Equals(value!, _expected!))
102102
{
103-
return Task.FromResult(AssertionResult.Passed);
103+
return AssertionResult._passedTask;
104104
}
105105

106106
return Task.FromResult(AssertionResult.Failed($"found {value}"));

0 commit comments

Comments
 (0)