Check that building height is in a sensible range.#1850
Merged
zerebubuth merged 1 commit intomasterfrom Mar 1, 2019
Merged
Conversation
Sometimes, data that doesn't make sense gets into OSM. For example, version 4 of [this building](https://www.openstreetmap.org/way/290535940) has `height=5e+70`, which is many orders of magnitude larger than the observable universe. Clearly this is a typo and causes problems for us when we try to write it out in tiles. This patch drops values outside a sensible range, which is approximately that of the tallest current structure, the Burj Khalifa.
iandees
approved these changes
Mar 1, 2019
nvkelso
approved these changes
Mar 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, data that doesn't make sense gets into OSM. For example, version 4 of this building has
height=5e+70, which is many orders of magnitude larger than the observable universe. Clearly this is a typo and causes problems for us when we try to write it out in tiles.This patch drops values outside a sensible range, which is approximately that of the tallest current structure, the Burj Khalifa.