Skip to content

Commit 116fb4c

Browse files
efkon-tkemtkem
authored andcommitted
Minor style and readability improvements.
1 parent 96546ea commit 116fb4c

3 files changed

Lines changed: 10 additions & 5 deletions

File tree

src/cachetools/__init__.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,9 @@ def __init__(self, maxsize, getsizeof=None):
154154

155155
def __setitem__(self, key, value, cache_setitem=Cache.__setitem__):
156156
cache_setitem(self, key, value)
157-
try:
157+
if key in self.__order:
158158
self.__order.move_to_end(key)
159-
except KeyError:
159+
else:
160160
self.__order[key] = None
161161

162162
def __delitem__(self, key, cache_delitem=Cache.__delitem__):
@@ -204,7 +204,8 @@ def __getitem__(self, key, cache_getitem=Cache.__getitem__):
204204
def __setitem__(self, key, value, cache_setitem=Cache.__setitem__):
205205
cache_setitem(self, key, value)
206206
if key in self.__links:
207-
return self.__touch(key)
207+
self.__touch(key)
208+
return
208209
root = self.__root
209210
link = root.next
210211
if link.count != 1:

src/cachetools/_cached.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,11 @@ def cache_clear():
109109
cache.clear()
110110
hits = misses = 0
111111

112+
def cache_info():
113+
return info(hits, misses)
114+
112115
wrapper.cache_clear = cache_clear
113-
wrapper.cache_info = lambda: info(hits, misses)
116+
wrapper.cache_info = cache_info
114117
return wrapper
115118

116119

src/cachetools/keys.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def hashkey(*args, **kwargs):
3838
"""Return a cache key for the specified hashable arguments."""
3939

4040
if kwargs:
41-
return _HashedTuple(args + sum(sorted(kwargs.items()), _kwmark))
41+
return _HashedTuple(args + _kwmark + tuple(sorted(kwargs.items())))
4242
else:
4343
return _HashedTuple(args)
4444

@@ -53,6 +53,7 @@ def typedkey(*args, **kwargs):
5353

5454
key = hashkey(*args, **kwargs)
5555
key += tuple(type(v) for v in args)
56+
# TODO: avoid iterating twice over kwargs
5657
key += tuple(type(v) for _, v in sorted(kwargs.items()))
5758
return key
5859

0 commit comments

Comments
 (0)