Convert root to array if root is a string #152#153
Conversation
fix issue #152,
Codecov Report
Continue to review full report at Codecov.
|
|
Hey, thanks for the contribution! This is looking ok, though the tests could be improved a bit. The test that you've added does not actually involve resolving the path, so the only thing that's being tested is the lack of an error when trying to run My suggestion is to replace arrays in the whole test suite with a string root (I did that in my fork too), and add one test that shows that two roots are working (currently there is no test like that). Would you be willing to do that @rohmanhm? |
I'm done. |
|
Ok, I think this can be merged! |
fix issue #152,