Skip to content

feat(dev): add loglevel to configure console logging#351

Merged
tleunen merged 1 commit into
tleunen:masterfrom
magento-research:magento-research/add-loglevel
Feb 11, 2019
Merged

feat(dev): add loglevel to configure console logging#351
tleunen merged 1 commit into
tleunen:masterfrom
magento-research:magento-research/add-loglevel

Conversation

@zetlen
Copy link
Copy Markdown
Contributor

@zetlen zetlen commented Jan 30, 2019

  • Add loglevel option
  • Disable missing path warning if loglevel is "silent"

We use this plugin to export a "virtual dependency" in our published modules, so that consumers of our module can override a deep dependency. We then alias the virtual module in Webpack config, not babel config. So we expect the virtual module not to exist at Babel build time.

Your plugin works great (thank you!) but it logs a lot of warnings due to our configuration, so we'd appreciate this option to quiet them.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2019

Codecov Report

Merging #351 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/normalizeOptions.js 100% <100%> (ø) ⬆️
src/resolvePath.js 100% <100%> (ø) ⬆️

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2019

Codecov Report

Merging #351 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/normalizeOptions.js 100% <100%> (ø) ⬆️
src/resolvePath.js 100% <100%> (ø) ⬆️

@tleunen
Copy link
Copy Markdown
Owner

tleunen commented Feb 11, 2019

I don't see why we couldn't have a log level option. Thank you for adding the documentation as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants