Add the resolvePath option#195
Merged
Merged
Conversation
Codecov Report
|
e693840 to
5a408af
Compare
Owner
|
One issue I see is that a user who decide to defines |
Contributor
Author
|
It's possible to import it from the plugin though; the default resolver is
exported and there's a test for supplying it through the resolvePath
option. Or is it about something else?
07.07.2017 1:04 AM "Tommy" <notifications@github.com> napisał(a):
One issue I see is that a user who decide to defines resolvePath for a very
specific use case has no way to call the default resolver (from the plugin)
for all other paths.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#195 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFuevkJfM7OjQPbWCRBhBuOtm5b7qIuoks5sLWfzgaJpZM4N2YiI>
.
|
Owner
|
Oh yes I see, indeed, the user can import the default function and use it explicitely as a fallback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
getRealPathoption, thus solving the #165 issue.I used the
getRealPathname, but maybe justtransformwould be good? But thengetRealPathis exposed in the module... I just have a tiny doubt about the name. Maybe it would be good to instead exposetransformand use that instead ofgetRealPathconsistently.I'm marking this as WIP because it depends on the changes from #194.