ci(deps): bump actions/upload-artifact from 4 to 5 #142
dependabot[bot]Annotations
1 error and 10 warnings
|
build
Process completed with exit code 1.
|
|
build:
tests/VivaldiModManager.Core.Tests/Extensions/DomainModelExtensionsTests.cs#L14
Missing XML comment for publicly visible type or member 'DomainModelExtensionsTests.GetEnabledModsInOrder_WithNullManifest_ThrowsArgumentNullException()'
|
|
build:
src/VivaldiModManager.Service/BackgroundServices/FileSystemMonitorService.cs#L207
Modify 'FileSystemMonitorService.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
build:
src/VivaldiModManager.Service/BackgroundServices/AutoHealService.cs#L585
Modify 'AutoHealService.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
build:
src/VivaldiModManager.Service/Services/IPCServerService.cs#L109
Modify 'IPCServerService.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
build:
src/VivaldiModManager.Service/BackgroundServices/IntegrityCheckService.cs#L164
Modify 'IntegrityCheckService.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
build:
src/VivaldiModManager.Service/Services/IPCServerService.cs#L19
Provide an overridable implementation of Dispose(bool) on 'IPCServerService' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
build:
src/VivaldiModManager.Service/BackgroundServices/IntegrityCheckService.cs#L38
Provide an overridable implementation of Dispose(bool) on 'IntegrityCheckService' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
build:
src/VivaldiModManager.Service/BackgroundServices/FileSystemMonitorService.cs#L50
Provide an overridable implementation of Dispose(bool) on 'FileSystemMonitorService' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
build:
src/VivaldiModManager.Service/BackgroundServices/AutoHealService.cs#L16
Provide an overridable implementation of Dispose(bool) on 'AutoHealService' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
build:
src/VivaldiModManager.Core/Services/VivaldiService.cs#L226
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|