Skip to content

Commit 8e2be07

Browse files
committed
CLI now ignores whitespace for resolver credentials
1 parent 30063b7 commit 8e2be07

2 files changed

Lines changed: 21 additions & 1 deletion

File tree

conductr_cli/resolvers/bintray_resolver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
BINTRAY_DOWNLOAD_BASE_URL = 'https://dl.bintray.com'
1515
BINTRAY_DOWNLOAD_REALM = 'Bintray'
1616
BINTRAY_CREDENTIAL_FILE_PATH = '{}/.lightbend/commercial.credentials'.format(os.path.expanduser('~'))
17-
BINTRAY_PROPERTIES_RE = re.compile('^(\S+)\s*=\s*([\S]+)$')
17+
BINTRAY_PROPERTIES_RE = re.compile('^\s*(\S+)\s*=\s*([\S]+)\s*$')
1818
BINTRAY_LIGHTBEND_ORG = 'lightbend'
1919
BINTRAY_CONDUCTR_COMMERCIAL_REPO = 'commercial-releases'
2020
BINTRAY_CONDUCTR_GENERIC_REPO = 'generic'

conductr_cli/resolvers/test/test_bintray_resolver.py

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -998,6 +998,26 @@ def test_success(self):
998998
exists_mock.assert_called_with('{}/.lightbend/commercial.credentials'.format(os.path.expanduser('~')))
999999
open_mock.assert_called_with('{}/.lightbend/commercial.credentials'.format(os.path.expanduser('~')), 'r')
10001000

1001+
def test_success_whitespace(self):
1002+
bintray_credential_file = strip_margin(
1003+
"""| user = user1
1004+
| password = sec=ret
1005+
|# Some comment
1006+
|""")
1007+
1008+
exists_mock = MagicMock(return_value=True)
1009+
open_mock = MagicMock(return_value=io.StringIO(bintray_credential_file))
1010+
1011+
with patch('os.path.exists', exists_mock), \
1012+
patch('builtins.open', open_mock):
1013+
realm, username, password = bintray_resolver.load_bintray_credentials()
1014+
self.assertEqual('Bintray', realm)
1015+
self.assertEqual('user1', username)
1016+
self.assertEqual('sec=ret', password)
1017+
1018+
exists_mock.assert_called_with('{}/.lightbend/commercial.credentials'.format(os.path.expanduser('~')))
1019+
open_mock.assert_called_with('{}/.lightbend/commercial.credentials'.format(os.path.expanduser('~')), 'r')
1020+
10011021
def test_credential_file_not_having_username_password(self):
10021022
bintray_credential_file = strip_margin(
10031023
"""|dummy = yes

0 commit comments

Comments
 (0)