From e745a283cfb7cd544acd46cee91146f18bfd5957 Mon Sep 17 00:00:00 2001
From: Marcus <marcusmiguel0612@gmail.com>
Date: Wed, 21 Jun 2023 19:16:25 -0300
Subject: [PATCH] proxy: show appropriate actions

---
 .../L2/Dropdowns/AccountsDropdown.tsx         |  2 +-
 src/lib/types/Point.ts                        |  8 +++---
 src/views/Ops/Ops.scss                        |  9 ++++++-
 src/views/Ops/Ops.tsx                         | 25 +++++++++++++------
 src/views/Point/Point.tsx                     | 11 ++++----
 src/views/UrbitID/Home.tsx                    | 19 +++++++-------
 6 files changed, 45 insertions(+), 29 deletions(-)

diff --git a/src/components/L2/Dropdowns/AccountsDropdown.tsx b/src/components/L2/Dropdowns/AccountsDropdown.tsx
index 48ea4572d..f4234b2bb 100644
--- a/src/components/L2/Dropdowns/AccountsDropdown.tsx
+++ b/src/components/L2/Dropdowns/AccountsDropdown.tsx
@@ -77,7 +77,7 @@ const AccountsDropdown = ({ showMigrate = false }: AccountsDropdownProps) => {
     point.value >= 0 ? point.patp : currentAddress.slice(0, 6);
 
   const displayedPoints = useMemo(
-    () => pointList.filter(({ ownManageSpawn }) => ownManageSpawn),
+    () => pointList.filter(({ ownManageSpawnVote }) => ownManageSpawnVote),
     [pointList]
   );
 
diff --git a/src/lib/types/Point.ts b/src/lib/types/Point.ts
index c73e02ba5..0d3755177 100644
--- a/src/lib/types/Point.ts
+++ b/src/lib/types/Point.ts
@@ -123,7 +123,7 @@ export default class Point {
   showInvites: boolean;
   isDefault: boolean;
   isPlaceholder: boolean;
-  ownManageSpawn: boolean;
+  ownManageSpawnVote: boolean;
   shouldDisplay: boolean;
   isOutgoing: boolean;
   permissionLevel: PermissionLevel;
@@ -206,11 +206,11 @@ export default class Point {
     this.showInvites = this.canManage || this.canSpawn;
     this.isDefault = value === -1;
     this.isPlaceholder = isPlaceholder;
-    this.ownManageSpawn =
+    this.ownManageSpawnVote =
       !this.isPlaceholder &&
       !this.isDefault &&
-      (this.isOwner || this.isSpawnProxy || this.isManagementProxy);
-    this.shouldDisplay = this.ownManageSpawn || this.isTransferProxy;
+      (this.isOwner || this.isSpawnProxy || this.isManagementProxy || this.isVotingProxy);
+    this.shouldDisplay = this.ownManageSpawnVote || this.isTransferProxy;
     this.isOutgoing =
       this.isTransferProxySet &&
       !this.isTransferProxy &&
diff --git a/src/views/Ops/Ops.scss b/src/views/Ops/Ops.scss
index 469937bb8..e788b904d 100644
--- a/src/views/Ops/Ops.scss
+++ b/src/views/Ops/Ops.scss
@@ -1,7 +1,14 @@
 .id-ops {
   .between-row {
-    .section-title, .subtitle {
+
+    .section-title,
+    .subtitle {
       font-size: 14px;
     }
   }
+
+  .disabled {
+    opacity: 0.5;
+    pointer-events: none;
+  }
 }
\ No newline at end of file
diff --git a/src/views/Ops/Ops.tsx b/src/views/Ops/Ops.tsx
index 61363936d..48da5bc70 100644
--- a/src/views/Ops/Ops.tsx
+++ b/src/views/Ops/Ops.tsx
@@ -67,7 +67,9 @@ export const Ops = () => {
           </Row>
         </HeaderPane>
         <BodyPane>
-          <Row className="between-row management">
+          <Row className={"between-row management" +
+            (point.canManage ? "" : " disabled")}
+          >
             <Box>
               <Box className="section-title">Residents</Box>
               <Box className="subtitle">
@@ -75,11 +77,15 @@ export const Ops = () => {
                 for
               </Box>
             </Box>
-            <Button className="secondary" onClick={goResidents}>
+            <Button className="secondary"
+              onClick={point.canManage ? goResidents : undefined}
+            >
               View
             </Button>
           </Row>
-          <Row className="between-row management">
+          <Row className={"between-row management" +
+            (point.canManage ? "" : " disabled")}
+          >
             <Box>
               <Box className="section-title">Requests</Box>
               <Box className="subtitle">
@@ -87,19 +93,24 @@ export const Ops = () => {
                 sponsorship
               </Box>
             </Box>
-            <Button className="secondary" onClick={goRequests}>
+            <Button className="secondary"
+              onClick={point.canManage ? goRequests : undefined}
+            >
               View
             </Button>
           </Row>
           {point.isGalaxy && (
-            <Row className="between-row management">
-              <Box>
+            <Row className={"between-row management" +
+              (point.canVote ? "" : " disabled")}
+            >
+              <Box >
                 <Box className="section-title">Proposals</Box>
                 <Box className="subtitle">
                   View or vote on proposals in the Senate
                 </Box>
               </Box>
-              <Button className="secondary" onClick={goSenate}>
+              <Button className="secondary"
+                onClick={point.canVote ? goSenate : undefined}>
                 View
               </Button>
             </Row>
diff --git a/src/views/Point/Point.tsx b/src/views/Point/Point.tsx
index fc0211d9d..e512066cb 100644
--- a/src/views/Point/Point.tsx
+++ b/src/views/Point/Point.tsx
@@ -82,7 +82,7 @@ export default function Point() {
     loadL2Info();
   }, [point]); // eslint-disable-line react-hooks/exhaustive-deps
 
-  const { isParent, canManage, isSpawnProxy } = point;
+  const { isParent, canManage, canVote, canSpawn } = point;
 
   const goUrbitOS = useCallback(() => {
     if (hideMessage) setSeenMissingKeys(hideMessage);
@@ -114,9 +114,8 @@ export default function Point() {
         <PendingTransaction
           layer={2}
           nextRoll={nextRoll}
-          title={`${spawnedPending} Planet${
-            spawnedPending > 1 ? 's' : ''
-          } Spawned`}
+          title={`${spawnedPending} Planet${spawnedPending > 1 ? 's' : ''
+            } Spawned`}
         />
       )}
       {!!otherPending.length &&
@@ -163,14 +162,14 @@ export default function Point() {
             />
           </Grid.Item>
         )}
-        {(canManage || isSpawnProxy) && (
+        {(canManage || canSpawn || canVote) && (
           <Grid.Item full as={Flex} justify="between">
             <Card
               title="ID"
               subtitle="Master Key, Passport, Proxy Addresses, etc"
               icon={(<Icon icon="User" />) as any}
               onClick={goUrbitID}
-              disabled={!(canManage || isSpawnProxy)}
+              disabled={!(canManage || canSpawn || canVote)}
             />
           </Grid.Item>
         )}
diff --git a/src/views/UrbitID/Home.tsx b/src/views/UrbitID/Home.tsx
index 0bd3f7825..788787a0c 100644
--- a/src/views/UrbitID/Home.tsx
+++ b/src/views/UrbitID/Home.tsx
@@ -56,7 +56,6 @@ export default function UrbitIDHome() {
   const goResetKeys = useCallback(() => push(names.RESET_KEYS), [push, names]);
 
   const isMasterTicket = Just.hasInstance(urbitWallet);
-  const { isOwner, canManage } = point;
   const networkRevision = convertToInt(point.keyRevisionNumber, 10);
 
   const goSetProxy = useCallback(
@@ -75,20 +74,20 @@ export default function UrbitIDHome() {
       <HeaderPane>
         <Row className="header-row">
           <h5>ID</h5>
-          {isMasterTicket && (
+          {isMasterTicket && point.isOwner && (
             <Button onClick={downloadKeys} className="header-button">
               {keysDownloaded
                 ? 'Downloaded!'
                 : paper.matchWith({
-                    Nothing: () => 'Printing and folding...',
-                    Just: (_: any) => 'Download Passport',
-                  })}
+                  Nothing: () => 'Printing and folding...',
+                  Just: (_: any) => 'Download Passport',
+                })}
             </Button>
           )}
         </Row>
       </HeaderPane>
       <BodyPane>
-        {isOwner && (
+        {point.isOwner && (
           <Row className="between-row owner">
             <Box>
               <Box>Ownership Address</Box>
@@ -105,7 +104,7 @@ export default function UrbitIDHome() {
           </Row>
         )}
 
-        {canManage && (
+        {point.canManage && (
           <Row className="between-row management">
             <Box>
               <Box>Management Address</Box>
@@ -131,7 +130,7 @@ export default function UrbitIDHome() {
           </Row>
         )}
 
-        {point.isParent && (
+        {point.canSpawn && (
           <Row className="between-row management">
             <Box>
               <Box>Spawn Proxy Address</Box>
@@ -156,7 +155,7 @@ export default function UrbitIDHome() {
           </Row>
         )}
 
-        {isOwner && (
+        {point.isOwner && (
           <Row className="between-row management">
             <WithTooltip content={MASTER_TICKET_TOOLTIP}>
               <Box>
@@ -193,7 +192,7 @@ export default function UrbitIDHome() {
           <Icon className="arrow-button" icon="ArrowEast" />
         </Row>
 
-        {point.isGalaxy && (
+        {point.canVote && (
           <Row className="between-row management">
             <Box>
               <Box>Edit Voting Key</Box>