Skip to content

Commit d62ac9c

Browse files
authored
Merge pull request #1378 from dearchap/issue_1334
Feature:(Issue 1334) Add support for uint64slices
2 parents 6ccecf2 + d0fff2e commit d62ac9c

9 files changed

Lines changed: 1285 additions & 13 deletions

.github/.codecov.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
comment: false
2+
coverage:
3+
threshold: 5%

altsrc/flag_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func (ris *racyInputSource) isSet(name string) bool {
4040
func TestGenericApplyInputSourceValue_Alias(t *testing.T) {
4141
v := &Parser{"abc", "def"}
4242
tis := testApplyInputSource{
43-
Flag: NewGenericFlag(&cli.GenericFlag{Name: "test", Aliases: []string{"test_alias"}, Value: &Parser{}}),
43+
Flag: NewGenericFlag(&cli.GenericFlag{Name: "test", Aliases: []string{"test_alias"}, Value: &Parser{}}),
4444
FlagName: "test_alias",
4545
MapValue: v,
4646
}

flag-spec.yaml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,12 @@ flag_types:
5555
- { name: Layout, type: string }
5656
- { name: Timezone, type: "*time.Location" }
5757

58-
# TODO: enable UintSlice
59-
# UintSlice: {}
60-
# TODO: enable Uint64Slice once #1334 lands
61-
# Uint64Slice: {}
58+
UintSlice:
59+
value_pointer: true
60+
skip_interfaces:
61+
- fmt.Stringer
62+
Uint64Slice:
63+
value_pointer: true
64+
skip_interfaces:
65+
- fmt.Stringer
66+

0 commit comments

Comments
 (0)