Fix double metdata when migrating

Author: Meldiron

composer.lock

@@ -2047,7 +2047,11 @@ public function createAttribute(string $collection, string $id, string $type, in
             }
         }
 
-        $collection->setAttribute('attributes', $attribute, Document::SET_TYPE_APPEND);
+        // Append attribute, removing any duplicates
+        $attributes = $collection->getAttribute('attributes', []);
+        $attributes = \array_filter($attributes, fn ($attr) => $attr['$id'] !== $id);
+        $attributes[] = $attribute;
+        $collection->setAttribute('attributes', \array_values($attributes));
 
         $this->updateMetadata(
             collection: $collection,
@@ -2169,10 +2173,17 @@ public function createAttributes(string $collection, array $attributes): bool
             }
         }
 
+        // Append attribute, removing any duplicates
+        $attributes = $collection->getAttribute('attributes', []);
+        $newAttributeIds = \array_map(fn ($attr) => $attr['$id'], $attributeDocuments);
+        $attributes = \array_filter($attributes, fn ($attr) => !\in_array($attr['$id'], $newAttributeIds));
+
         foreach ($attributeDocuments as $attributeDocument) {
-            $collection->setAttribute('attributes', $attributeDocument, Document::SET_TYPE_APPEND);
+            $attributes[] = $attributeDocument;
         }
 
+        $collection->setAttribute('attributes', \array_values($attributes));
+
         $this->updateMetadata(
             collection: $collection,
             rollbackOperation: fn () => $this->cleanupAttributes($collection->getId(), $attributeDocuments),

src/Database/Database.php

@@ -2195,4 +2195,50 @@ public function testCreateAttributesDelete(): void
         $this->assertCount(1, $attrs);
         $this->assertEquals('b', $attrs[0]['$id']);
     }
+
+    public function testCreateAttributeWhileMigrating(): void
+    {
+        /** @var Database $database */
+        $database = $this->getDatabase();
+
+        // Skip test if adapter doesn't support shared tables
+        if (!$database->getAdapter()->getSharedTables()) {
+            $this->expectNotToPerformAssertions();
+            return;
+        }
+
+        // Prepare collection
+        $database->createCollection('migration_test');
+        $database->setMigrating(true);
+
+        // First creation, as usual
+        $this->assertTrue($database->createAttribute('migration_test', 'status', Database::VAR_STRING, 128, true));
+
+        $collection = $database->getCollection('migration_test');
+        $attributes = $collection->getAttribute('attributes');
+        $this->assertCount(1, $attributes);
+        $this->assertEquals('status', $attributes[0]['$id']);
+
+        // Second creation, no exceptions, no duplicates
+        $result = $database->createAttribute('migration_test', 'status', Database::VAR_STRING, 128, true);
+        $this->assertTrue($result);
+
+        $collection = $database->getCollection('migration_test');
+        $attributes = $collection->getAttribute('attributes');
+        $this->assertCount(1, $attributes);
+        $this->assertEquals('status', $attributes[0]['$id']);
+
+        // Third creation, same as second, once more, just in case
+        $result = $database->createAttribute('migration_test', 'status', Database::VAR_STRING, 128, true);
+        $this->assertTrue($result);
+
+        $collection = $database->getCollection('migration_test');
+        $attributes = $collection->getAttribute('attributes');
+        $this->assertCount(1, $attributes);
+        $this->assertEquals('status', $attributes[0]['$id']);
+
+        // Cleanup
+        $database->setMigrating(false);
+        $database->deleteCollection('migration_test');
+    }
 }