Skip to content

Commit a0ce6e5

Browse files
committed
Stabilize catchError CI failures
1 parent 445a7b8 commit a0ce6e5

4 files changed

Lines changed: 17 additions & 4 deletions

File tree

packages/next/error.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,8 @@ try {
99
errorModule = {}
1010
}
1111

12-
module.exports = errorModule
12+
const ErrorComponent = errorModule.default || errorModule
13+
14+
module.exports = ErrorComponent
15+
Object.assign(module.exports, errorModule)
16+
module.exports.default = ErrorComponent
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1-
export default function Page() {
1+
export const dynamic = 'force-dynamic'
2+
3+
export default function Page(): never {
24
throw new Error('navigation reset test')
35
}

test/e2e/app-dir/catch-error/catch-error.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,9 @@ describe('app-dir - catchError', () => {
9191
await browser.waitForElementByCss('#navigation-reset-error')
9292

9393
expect(await browser.elementByCss('#navigation-reset-error').text()).toBe(
94-
'navigation reset test'
94+
isNextDev
95+
? 'navigation reset test'
96+
: 'An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.'
9597
)
9698

9799
await browser.elementByCss('#navigation-reset-safe-link').click()

test/e2e/app-dir/errors/index.test.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,12 @@ import stripAnsi from 'strip-ansi'
88
*/
99
function normalizeComponentStack(stack: string): string[] {
1010
// Match "at ComponentName" patterns, optionally with [Server] tag
11-
return stack.match(/at \w+(?:\s+\[Server\])?/g) || []
11+
return (stack.match(/at \w+(?:\s+\[Server\])?/g) || []).map((component) =>
12+
component.replace(
13+
'InnerScrollAndFocusHandlerOld',
14+
'InnerScrollAndFocusHandler'
15+
)
16+
)
1217
}
1318

1419
describe('app-dir - errors', () => {

0 commit comments

Comments
 (0)