refactor: write pages router export files directly to server/pages/#90018
Draft
bgub wants to merge 1 commit intovercel:canaryfrom
Draft
refactor: write pages router export files directly to server/pages/#90018bgub wants to merge 1 commit intovercel:canaryfrom
bgub wants to merge 1 commit intovercel:canaryfrom
Conversation
Instead of exporting pages to a temp directory and then moving them, have the export worker write directly to .next/server/pages/. This eliminates the moveExportedPage step and the temporary export folder. - Replace moveExportedPage with updatePagesManifestForExportedPage (synchronous manifest-only updates, no file I/O) - Redirect export worker outDir/pagesDataDir to server/pages/ during buildExport - Skip outDir cleanup during buildExport (no temp dir created) - Delete notFound i18n SSG files that the worker wrote but shouldn't be served - Fix output:"export" copy step to read pages router files from server/pages/ directly instead of getPagePath-based paths
bgub
changed the title
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.next/server/pagesduringbuildExportinstead of writing todist/exportand moving afterwardpages-manifestentries directly and removing the export temp directory move/cleanup flownotFoundartifacts fromserver/pagesand pointing static export copy logic at the new pages-router output location