Skip to content

[using-preact] Update example to Preact X#9079

Merged
Timer merged 3 commits into
vercel:canaryfrom
rafaelalmeidatk:fix/preact-example
Oct 16, 2019
Merged

[using-preact] Update example to Preact X#9079
Timer merged 3 commits into
vercel:canaryfrom
rafaelalmeidatk:fix/preact-example

Conversation

@rafaelalmeidatk
Copy link
Copy Markdown
Contributor

@rafaelalmeidatk rafaelalmeidatk commented Oct 15, 2019 •
edited
Loading

I updated the example to use the newest major of Preact: Preact X, which included the compat library into the core.

I took the liberty to remove the @zeit/next-preact lib from the example because:

  • The user has more control about what is going on with the aliases
  • The user doesn't have to depend on the library to update Preact (the lib has Preact as a peerDependency but it is still an issue if you want to update out of the version range)
  • Having everything in the example makes it clear and is easier to update

What do you think?

Fixes #9057

@ijjk
Copy link
Copy Markdown
Member

ijjk commented Oct 15, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
buildDuration 16s 16.5s ⚠️ +451ms
nodeModulesSize 48.5 MB 48.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..9dda6167a.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..167a.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..3a0560775.js 43.2 kB 43.2 kB ✓
de003c3a9d30..0775.js gzip 15.5 kB 15.5 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..72.module.js 45.6 kB 45.6 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Rendered Page Sizes
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
index.html 3.62 kB 3.62 kB ✓
index.html gzip 946 B 946 B ✓
link.html 3.66 kB 3.66 kB ✓
link.html gzip 954 B 954 B ✓
withRouter.html 3.67 kB 3.67 kB ✓
withRouter.html gzip 941 B 941 B ✓
Overall change 10.9 kB 10.9 kB ✓
Serverless Mode
General
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
buildDuration 16.5s 16.4s -85ms
nodeModulesSize 48.5 MB 48.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..9dda6167a.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..167a.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..3a0560775.js 43.2 kB 43.2 kB ✓
de003c3a9d30..0775.js gzip 15.5 kB 15.5 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..72.module.js 45.6 kB 45.6 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Serverless bundles
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_error.js 254 kB 254 kB ✓
_error.js gzip 68 kB 68 kB ✓
hooks.html 3.75 kB 3.75 kB ✓
hooks.html gzip 979 B 979 B ✓
index.js 254 kB 254 kB ✓
index.js gzip 68.4 kB 68.4 kB ✓
link.js 262 kB 262 kB ✓
link.js gzip 70.4 kB 70.4 kB ✓
routerDirect.js 255 kB 255 kB ✓
routerDirect.js gzip 68.4 kB 68.4 kB ✓
withRouter.js 255 kB 255 kB ✓
withRouter.js gzip 68.5 kB 68.5 kB ✓
Overall change 1.28 MB 1.28 MB ✓

Commit: fdca53f

@Timer Timer added this to the 9.1.2 milestone Oct 16, 2019
@Timer Timer added ready to land examples Issue was opened via the examples template. labels Oct 16, 2019
Timer
Timer approved these changes Oct 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Timer Timer mentioned this pull request Oct 16, 2019
Merged
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Oct 16, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
buildDuration 15.6s 16s ⚠️ +318ms
nodeModulesSize 48.5 MB 48.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..9dda6167a.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..167a.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..3a0560775.js 43.2 kB 43.2 kB ✓
de003c3a9d30..0775.js gzip 15.5 kB 15.5 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..72.module.js 45.6 kB 45.6 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Rendered Page Sizes
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
index.html 3.5 kB 3.5 kB ✓
index.html gzip 944 B 944 B ✓
link.html 3.55 kB 3.55 kB ✓
link.html gzip 951 B 951 B ✓
withRouter.html 3.56 kB 3.56 kB ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 10.6 kB 10.6 kB ✓
Serverless Mode
General
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
buildDuration 15.6s 15.8s ⚠️ +146ms
nodeModulesSize 48.5 MB 48.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..9dda6167a.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..167a.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..3a0560775.js 43.2 kB 43.2 kB ✓
de003c3a9d30..0775.js gzip 15.5 kB 15.5 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..72.module.js 45.6 kB 45.6 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Serverless bundles
zeit/next.js canary rafaelalmeidatk/next.js fix/preact-example Change
_error.js 255 kB 255 kB ✓
_error.js gzip 68.2 kB 68.2 kB ✓
hooks.html 3.64 kB 3.64 kB ✓
hooks.html gzip 974 B 974 B ✓
index.js 255 kB 255 kB ✓
index.js gzip 68.5 kB 68.5 kB ✓
link.js 263 kB 263 kB ✓
link.js gzip 70.5 kB 70.5 kB ✓
routerDirect.js 256 kB 256 kB ✓
routerDirect.js gzip 68.6 kB 68.6 kB ✓
withRouter.js 256 kB 256 kB ✓
withRouter.js gzip 68.7 kB 68.7 kB ✓
Overall change 1.29 MB 1.29 MB ✓

Commit: 8a63463

@Timer Timer merged commit 4dd4df1 into vercel:canary Oct 16, 2019
@rafaelalmeidatk rafaelalmeidatk deleted the fix/preact-example branch October 17, 2019 03:19
This was referenced Nov 12, 2019
Merged
Open
Open
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees

No one assigned

Labels

examples Issue was opened via the examples template.

Projects

None yet

Milestone

9.1.2

Development

Successfully merging this pull request may close these issues.

Preact example doesn't start or build

3 participants

@rafaelalmeidatk @ijjk @Timer