fix: consider URLs with any protocol to be external (#17369)

asivery · patak-cat · bluwy · web-flow · commit a0336bd5197b · 2024-10-29T16:10:47.000+08:00
Co-authored-by: patak-dev &lt;matias.capeletto@gmail.com&gt;
Co-authored-by: bluwy &lt;bjornlu.dev@gmail.com&gt;
Co-authored-by: sapphi-red &lt;49056869+sapphi-red@users.noreply.github.com&gt;
diff --git a/packages/vite/src/node/plugins/importAnalysis.ts b/packages/vite/src/node/plugins/importAnalysis.ts
@@ -509,7 +509,10 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
           // If resolvable, let's resolve it
           if (specifier !== undefined) {
             // skip external / data uri
-            if (isExternalUrl(specifier) || isDataUrl(specifier)) {
+            if (
+              (isExternalUrl(specifier) && !specifier.startsWith('file://')) ||
+              isDataUrl(specifier)
+            ) {
               return
             }
             // skip ssr externals and builtins
diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts
@@ -262,7 +262,7 @@ export function isSameFileUri(file1: string, file2: string): boolean {
   )
 }
 
-export const externalRE = /^(https?:)?\/\//
+export const externalRE = /^([a-z]+:)?\/\//
 export const isExternalUrl = (url: string): boolean => externalRE.test(url)
 
 export const dataUrlRE = /^\s*data:/i

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ export function isSameFileUri(file1: string, file2: string): boolean {`
`262`	`262`	`)`
`263`	`263`	`}`
`264`	`264`
`265`		`-export const externalRE = /^(https?:)?\/\//`
	`265`	`+export const externalRE = /^([a-z]+:)?\/\//`
`266`	`266`	`export const isExternalUrl = (url: string): boolean => externalRE.test(url)`
`267`	`267`
`268`	`268`	`export const dataUrlRE = /^\s*data:/i`