fix: respect resolve.conditions during nodeResolve

Upstream: #13487

Author: himself65

packages/vite/src/node/ssr/ssrModuleLoader.ts

@@ -121,15 +121,15 @@ async function instantiateModule(
 
   const {
     isProduction,
-    resolve: { dedupe, preserveSymlinks },
+    resolve: { dedupe, preserveSymlinks, conditions },
     root,
   } = server.config
 
   const resolveOptions: InternalResolveOptionsWithOverrideConditions = {
     mainFields: ['main'],
     browserField: true,
     conditions: [],
-    overrideConditions: ['production', 'development'],
+    overrideConditions: [...conditions, 'production', 'development'],
     extensions: ['.js', '.cjs', '.json'],
     dedupe,
     preserveSymlinks,

playground/ssr-deps/__tests__/ssr-deps.spec.ts

@@ -122,6 +122,13 @@ test('import css library', async () => {
   expect(await page.textContent('.module-condition')).toMatch('[success]')
 })
 
+test('import react/server/server.node.unbundled.js', async () => {
+  await page.goto(url)
+  expect(await page.textContent('.react-server')).toMatch(
+    'server.node.unbundled.js',
+  )
+})
+
 describe.runIf(isServe)('hmr', () => {
   test('handle isomorphic module updates', async () => {
     await page.goto(url)

playground/ssr-deps/package.json

@@ -17,6 +17,7 @@
     "@vitejs/test-object-assigned-exports": "file:./object-assigned-exports",
     "@vitejs/test-only-object-assigned-exports": "file:./only-object-assigned-exports",
     "@vitejs/test-primitive-export": "file:./primitive-export",
+    "@vitejs/test-react-server": "file:./react-server",
     "@vitejs/test-read-file-content": "file:./read-file-content",
     "@vitejs/test-require-absolute": "file:./require-absolute",
     "@vitejs/test-ts-transpiled-exports": "file:./ts-transpiled-exports",

playground/ssr-deps/react-server/package.json

@@ -0,0 +1,21 @@
+{
+  "name": "@vitejs/test-react-server",
+  "private": true,
+  "type": "module",
+  "version": "0.0.0",
+  "exports": {
+    "./server": {
+      "react-server": {
+        "workerd": "./server.edge.js",
+        "deno": "./server.browser.js",
+        "node": {
+          "webpack": "./server.node.js",
+          "default": "./server.node.unbundled.js"
+        },
+        "edge-light": "./server.edge.js",
+        "browser": "./server.browser.js"
+      },
+      "default": "./server.js"
+    }
+  }
+}

playground/ssr-deps/react-server/server.browser.js

@@ -0,0 +1 @@
+export default 'server.browser.js'

playground/ssr-deps/react-server/server.edge.js

@@ -0,0 +1 @@
+export default 'server.edge.js'

playground/ssr-deps/react-server/server.js

@@ -0,0 +1 @@
+export default 'server.js'

playground/ssr-deps/react-server/server.node.js

@@ -0,0 +1 @@
+export default 'server.node.js'

playground/ssr-deps/react-server/server.node.unbundled.js

@@ -0,0 +1 @@
+export default 'server.node.unbundled.js'

playground/ssr-deps/server.js

@@ -21,6 +21,9 @@ export async function createServer(root = process.cwd(), hmrPort) {
   ).createServer({
     root,
     logLevel: isTest ? 'error' : 'info',
+    resolve: {
+      conditions: ['react-server'],
+    },
     server: {
       middlewareMode: true,
       watch: {