Skip to content

refactor: remove unnecessary escape#18044

Merged
patak-cat merged 2 commits intovitejs:mainfrom
btea:refactor/remove-unnecessary-escape
Sep 9, 2024
Merged

refactor: remove unnecessary escape#18044
patak-cat merged 2 commits intovitejs:mainfrom
btea:refactor/remove-unnecessary-escape

Conversation

@btea
Copy link
Copy Markdown
Contributor

@btea btea commented Sep 6, 2024

Description

Remove unnecessary character escape.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@btea btea added the p1-chore Doesn't change code behavior (priority) label Sep 8, 2024
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are covered by no-useless-escape.
It was disabled here and I think we should remove it:

'no-useless-escape': 'off',

@btea
Copy link
Copy Markdown
Contributor Author

btea commented Sep 9, 2024

Thanks for your review, I have updated it.

Copy link
Copy Markdown
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-cat patak-cat merged commit 8062d36 into vitejs:main Sep 9, 2024
@btea btea deleted the refactor/remove-unnecessary-escape branch September 9, 2024 10:17
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants