Skip to content

fix(html): escape html attribute#18067

Merged
patak-cat merged 2 commits intovitejs:mainfrom
sunnylost:fix-html-attribute-encode
Sep 10, 2024
Merged

fix(html): escape html attribute#18067
patak-cat merged 2 commits intovitejs:mainfrom
sunnylost:fix-html-attribute-encode

Conversation

@sunnylost
Copy link
Copy Markdown
Contributor

Fixes #18040

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Comment thread packages/vite/src/node/plugins/html.ts Outdated
@sapphi-red sapphi-red added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Sep 10, 2024
Co-authored-by: 翠 / green <green@sapphi.red>
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-cat patak-cat merged commit 5983f36 into vitejs:main Sep 10, 2024
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
Co-authored-by: 翠 / green <green@sapphi.red>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: html p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improper escaping of HTML attribute when transformIndexHtml is used

3 participants