fix(css): remove alias exclude logic from rebaseUrl#20100
Merged
patak-cat merged 1 commit intovitejs:mainfrom May 26, 2025
Merged
Conversation
patak-cat
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This part of code was added by #2323.
vite/packages/vite/src/node/plugins/css.ts
Lines 2774 to 2783 in a33d0c7
This excludes
url(value)s that uses aliases from being rebased. Then that was rebased byUrlRewritePostcssPlugin.vite/packages/vite/src/node/plugins/css.ts
Lines 1522 to 1526 in a33d0c7
While this works fine in most cases, this is incorrect when the replacement is a relative path (e.g.
alias: { '@foo': '../foo' }).That said, this PR would make the implementation more simple and that was the initial motivation.