chore: add a way to disable source maps when developing Vite#20168
Merged
sapphi-red merged 2 commits intovitejs:mainfrom Jun 6, 2025
Merged
Conversation
…ble it when running tests
hi-ogawa
previously approved these changes
Jun 6, 2025
Contributor
hi-ogawa
left a comment
hi-ogawa
left a comment
There was a problem hiding this comment.
Sounds good to me, but is there any specific issue you see in tests? I think this won't affect most of the tests (except playground/cli ,cli-module?) since they don't load cli packages/vite/bin/vite.js.
Member
Author
|
I vaguely remembered that you encountered this kind of problem in past. But you're right, it won't happen with tests. Let remove that part. |
sapphi-red
commented
Jun 6, 2025
sapphi-red
changed the title
hi-ogawa
approved these changes
Jun 6, 2025
Contributor
hi-ogawa
left a comment
hi-ogawa
left a comment
There was a problem hiding this comment.
Hmm, I also vaguely remember I said something about it, but forgot 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an env var to disable source maps when developing Vite.
Also set that env var when running tests.