Skip to content

feat(css): use esbuild.log* options when minifying (fixes #9196) #9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-dev merged 1 commit into from
Jul 19, 2022
Merged

feat(css): use esbuild.log* options when minifying (fixes #9196) #9210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/vite/src/node/plugins/css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,18 +1249,25 @@ async function minifyCSS(css: string, config: ResolvedConfig) {
function resolveEsbuildMinifyOptions(
options: ESBuildOptions
): TransformOptions {
const base: TransformOptions = {
logLevel: options.logLevel,
logLimit: options.logLimit,
logOverride: options.logOverride
}

if (
options.minifyIdentifiers != null ||
options.minifySyntax != null ||
options.minifyWhitespace != null
) {
return {
...base,
minifyIdentifiers: options.minifyIdentifiers ?? true,
minifySyntax: options.minifySyntax ?? true,
minifyWhitespace: options.minifyWhitespace ?? true
}
} else {
return { minify: true }
return { ...base, minify: true }
}
}

Expand Down
7 changes: 7 additions & 0 deletions playground/css/__tests__/css.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,3 +442,10 @@ test('aliased css has content', async () => {
// expect(await page.textContent('.aliased-content')).toMatch('.aliased')
expect(await getColor('.aliased-module')).toBe('blue')
})

test.runIf(isBuild)('warning can be suppressed by esbuild.logOverride', () => {
serverLogs.forEach((log) => {
// no warning from esbuild css minifier
expect(log).not.toMatch('unsupported-css-property')
})
})
2 changes: 2 additions & 0 deletions playground/css/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,5 @@ import aliasModule from '#alias-module'
document
.querySelector('.aliased-module')
.classList.add(aliasModule.aliasedModule)

import './unsupported.css'
3 changes: 3 additions & 0 deletions playground/css/unsupported.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.unsupported {
overflow-x: hidden;
}
5 changes: 5 additions & 0 deletions playground/css/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ module.exports = {
build: {
cssTarget: 'chrome61'
},
esbuild: {
logOverride: {
'unsupported-css-property': 'silent'
}
},
resolve: {
alias: {
'@': __dirname,
Expand Down