govc: fix integer type conversion

tenthirtyam · tenthirtyam · commit a8997d55c71d · 2025-03-17T20:24:36.000-04:00
Added a check to panic if a value exceeds `math.MaxInt32` in the `Interval` method to prevent out-of-range errors.

Signed-off-by: Ryan Johnson &lt;ryan.johnson@broadcom.com&gt;
diff --git a/cli/metric/performance.go b/cli/metric/performance.go
@@ -20,6 +20,7 @@ import (
 	"context"
 	"flag"
 	"fmt"
+	"math"
 	"strconv"
 
 	"github.com/vmware/govmomi/cli/flags"
@@ -88,7 +89,12 @@ func (f *PerformanceFlag) Interval(val int32) int32 {
 			if err != nil {
 				panic(err)
 			}
-			interval = int32(n)
+
+			if n > math.MaxInt32 {
+				panic(fmt.Errorf("value out of range for int32: %d", n))
+			} else {
+				interval = int32(n)
+			}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ import (`
`20`	`20`	`"context"`
`21`	`21`	`"flag"`
`22`	`22`	`"fmt"`
	`23`	`+ "math"`
`23`	`24`	`"strconv"`
`24`	`25`
`25`	`26`	`"github.com/vmware/govmomi/cli/flags"`
`@@ -88,7 +89,12 @@ func (f *PerformanceFlag) Interval(val int32) int32 {`
`88`	`89`	`if err != nil {`
`89`	`90`	`panic(err)`
`90`	`91`	`}`
`91`		`- interval = int32(n)`
	`92`	`+`
	`93`	`+ if n > math.MaxInt32 {`
	`94`	`+ panic(fmt.Errorf("value out of range for int32: %d", n))`
	`95`	`+ } else {`
	`96`	`+ interval = int32(n)`
	`97`	`+ }`
`92`	`98`	`}`
`93`	`99`	`}`
`94`	`100`