Home Feed: make Bookmarks properly reactive.#6599
Open
dbrant wants to merge 167 commits into
Open
Conversation
* - adds navigation arch * - simplify navigation
* - adds ExploreFeedUpdatePromptActivity - adds strings for ExploreFeedUpdatePromptActivity - adds preference for controlling ExploreFeedUpdatePromptActivity access - adds icon resources * - open explore feed update prompt from feed fragment - code fixes * - code fixes
* Explore Feed: Onboarding: Intro Screens and Context Setting * Integrate with the initialOnboardingActivity * Almost * Optimize * Code review comments * Update asset, function and handle navigation bar correctly
…ps-android-wikipedia into explore-feed-upgrade-design
* NewExploreFeed: the Feed building screen * Update asset and ready for design signoff
* NewExploreFeed: Languages pick screen * Callbacks * Finishing up * Language pick * Add language selection to initialOnboarding screen * Fix * Update content description
* Allow edge-to-edge for MainActivity, enabling full-bleed compositions. * Remove redundant name. * Initial exploration of HomeFragment. * Yes. * Remember snap fling state. * Yep. * Bunch of hacks for applying non-default theme colors to NavBar. * Imports. * Explicitly set LightSystemUiVisibility. * Framework for Home fragment in Compose. * Properly account for status bar inset. * Refactor a bit. * Further solidify. * Break out ViewModel. * Review comments. * Remove annotation. * Apply different themes when switching tabs, and fill out some more. * OK... * Wire up. * Alright... * Alright!
* NewExploreFeed: rename "Explore" to "Home" * update for strings that may not be used later * add qq strings * Code review comments * Fix merge issue * Fix reference
* Community Picks: Top Read Module * Better paddings * wire to home * Clickable area: * click behavior * Adding trending up/down icons * Update token * Finalized * Pull to refresh * show localized name in the description * Remove language text
…ps-android-wikipedia into explore-feed-upgrade-design
…ps-android-wikipedia into explore-feed-upgrade-design
* - adds community module settings * - adds for you module settings * - creates a common toggle style setting screen called ToggleListScreen - code fixes * - adds link support to description in settings row - adds proper naming - ui/code fixes * - code fixes * - code fixes * - string fixes --------- Co-authored-by: Cooltey Feng <cfeng@wikimedia.org>
…ps-android-wikipedia into explore-feed-upgrade-design
* Add strings for swipe-to-explore prompt in the new explore feed * Add preference * Finalized * Simplified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a proper™ way of handling reading list bookmark states in the Feed, using a StateFlow that is directly integrated into the Room query.
With not too much more code, the bookmark state becomes fully reactive and Compose-worthy.