Updated expander animations and removed layout updates#2527
Merged
Conversation
JustinXinLiu
approved these changes
Oct 8, 2018
azchohfi
approved these changes
Oct 8, 2018
michael-hawker
requested changes
Oct 8, 2018
| UpdateOverlayAlignment(); | ||
| if (GetTemplateChild(ContentOverlayPart) is Grid contentOverlay) | ||
| { | ||
| contentOverlay.Visibility = ContentOverlay != null ? Visibility.Visible : Visibility.Collapsed; |
Member
There was a problem hiding this comment.
We can use the EmptyObjectToObjectConverter to create a 'NullToVisibilityConverter' and do this all in the template. Then we can get rid of the ContentOverlay part entirely.
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Good idea, done. Please review again
michael-hawker
approved these changes
Oct 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2372
Supplemental PR to #2397
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The expander has weird animation jumps when opening and closing
What is the new behavior?
Expander animations are smooth without any jumps
PR Checklist
Please check if your PR fulfills the following requirements: