OnDevice markup extension added (take 2)#2687
Merged
michael-hawker merged 17 commits intoCommunityToolkit:masterfrom Dec 7, 2018
sonnemaf:OnDevice
Merged
OnDevice markup extension added (take 2)#2687michael-hawker merged 17 commits intoCommunityToolkit:masterfrom sonnemaf:OnDevice
michael-hawker merged 17 commits intoCommunityToolkit:masterfrom
sonnemaf:OnDevice
Conversation
michael-hawker
requested changes
Nov 27, 2018
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
@nmetulev any concerns with exposing the AnalyticsVersion extension in Microsoft.Toolkit.Uwp? It seems like a thing people do anyway, so might as well make it consistent somewhere.
| <Name>Visual C++ 2015 Runtime for Universal Windows Platform Apps</Name> | ||
| </SDKReference> | ||
| </ItemGroup> | ||
| <ItemGroup /> |
kbrons
reviewed
Nov 27, 2018
Member
|
@sonnemaf where are the icons in the new thumbnail sourced from? |
lindexi
reviewed
Nov 30, 2018
| /// </summary> | ||
| public sealed partial class OnDevicePage : IXamlRenderListener | ||
| { | ||
|
|
lindexi
reviewed
Nov 30, 2018
| "Icon": "/Assets/Helpers.png", | ||
| "DocumentationUrl": "https://raw.githubusercontent.com/MicrosoftDocs/WindowsCommunityToolkitDocs/master/docs/helpers/ThemeListener.md" | ||
| } | ||
| } |
michael-hawker
approved these changes
Dec 5, 2018
Member
|
@michael-hawker Yes |
nmetulev
approved these changes
Dec 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2489 and #2664
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information