Skip to content

Comments

fix a problem when parsing with ---\n---\n#3388

Merged
Sergio0694 merged 3 commits intoCommunityToolkit:masterfrom
takano03:fixYamlHeaderParser2
Jul 26, 2020
Merged

fix a problem when parsing with ---\n---\n#3388
Sergio0694 merged 3 commits intoCommunityToolkit:masterfrom
takano03:fixYamlHeaderParser2

Conversation

@takano03
Copy link
Contributor

@takano03 takano03 commented Jul 14, 2020 •
edited by Kyaa-dost
Loading

Fixes #3385

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

#3385

What is the new behavior?

#3385

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Jul 14, 2020

Thanks takano03 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned azchohfi Jul 14, 2020
@takano03 takano03 mentioned this pull request Jul 14, 2020
Closed
Kyaa-dost
Kyaa-dost approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Jul 17, 2020
@Sergio0694 Sergio0694 merged commit d1c9e73 into CommunityToolkit:master Jul 26, 2020
@Sergio0694
Copy link
Member

Sergio0694 commented Jul 26, 2020

Merged! Thanks @takano03 for the bug fix! 🎉

@michael-hawker michael-hawker added the markdown 📑 Issues related to Markdown label Jul 27, 2020
@michael-hawker michael-hawker added this to the 7.0 milestone Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vgromfeld vgromfeld vgromfeld approved these changes

@Kyaa-dost Kyaa-dost Kyaa-dost approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@azchohfi azchohfi

Labels

bug 🐛 An unexpected issue that highlights incorrect behavior markdown 📑 Issues related to Markdown

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

ArgumentOutOfRangeException in the markdown parser with "---\n---\n".

6 participants

@takano03 @Sergio0694 @vgromfeld @Kyaa-dost @azchohfi @michael-hawker