Shameful rename of [IsNullOr]WhiteSpace Guard APIs#3515
Merged
3 commits merged intoCommunityToolkit:masterfrom Oct 6, 2020
Merged
Shameful rename of [IsNullOr]WhiteSpace Guard APIs#35153 commits merged intoCommunityToolkit:masterfrom
3 commits merged intoCommunityToolkit:masterfrom
Conversation
Sergio0694
added
improvements ✨
.NET
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
Rosuavio
approved these changes
Oct 5, 2020
vgromfeld
approved these changes
Oct 6, 2020
|
Hello @Sergio0694! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Some
GuardAPIs were incorrectly using the wrong capitalization for theWhiteSpacepart, not following the same structure of the actual APIs in the BCL (eg.string.IsNullOrWhiteSpace). This PR deprecates them and adds new APIs with the right name....I'm sorry 😅
PR Type
What kind of change does this PR introduce?
PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templatesTests for the changes have been added (for bug fixes / features) (if applicable)Header has been added to all new source files (run build/UpdateHeaders.bat)