Skip to content

Comments

Additional Smoke Test Scripts#3690

Merged
michael-hawker merged 3 commits intoCommunityToolkit:masterfrom
michael-hawker:Smoke-test-Scripts
Jan 26, 2021
Merged

Additional Smoke Test Scripts#3690
michael-hawker merged 3 commits intoCommunityToolkit:masterfrom
michael-hawker:Smoke-test-Scripts

Conversation

@michael-hawker
Copy link
Member

Adds some additional metrics for how the smoke test projects impact compiled binary sizes.

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes

What is the current behavior?

Only outputs the loose dll sizes

What is the new behavior?

Also looks at the compiled application size.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

There's another script to help in downloading a specific NuGet package version, though the version passing into the SmokeTests has to be disabled manually currently to make most effective use of it.

Note: Still needs extra work to build/analyze smoke tests after as Version pinned by Nerdbank for CI.
@ghost
Copy link

ghost commented Jan 26, 2021

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from Kyaa-dost, Rosuavio and azchohfi January 26, 2021 17:44
@michael-hawker michael-hawker merged commit 5553f45 into CommunityToolkit:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants