Removed System.ValueTuple package reference from Animations

[Sergio0694]

PR Type

What kind of change does this PR introduce?

• Dependency reduction

What is the current behavior?

The .Animations package has a reference on System.ValueTuple that we don't actually need or use.

What is the new behavior?

That reference is no longer there. This can possibly bring a small reduction in binary size, but most importantly it will avoid having public APIs leaking to consumers through indirect references that are hard to keep track of.

Package analysis diff

- Microsoft.Toolkit.Uwp.UI.Animations Additional Max Footprint: 623,163 bytes
+ Microsoft.Toolkit.Uwp.UI.Animations Additional Max Footprint: 591,830 bytes
  Microsoft.Toolkit.Uwp.UI.Animations Additional Min Footprint: 4,099,518 bytes
  App Diff: (.exe) = 26,624
  App Diff: (.xml) = 2,287
- App Diff: (.appxsym) = 110,360
+ App Diff: (.appxsym) = 110,356
  Size Diff: AppxBundleManifest.xml = 25
- Size Diff: AppxBlockMap.xml = 1,011
+ Size Diff: AppxBlockMap.xml = 1,010
  Size Diff: AppxManifest.xml = 24
  Size Diff: resources.pri = 2,480
- Additional: Microsoft.Toolkit.dll = 38,040
- Additional: Microsoft.Toolkit.Uwp.dll = 111,256
- Lib (self): Microsoft.Toolkit.Uwp.UI.Animations.dll = 171,672
- Additional: Microsoft.Toolkit.Uwp.UI.dll = 159,384
+ Additional: Microsoft.Toolkit.dll = 30,208
+ Additional: Microsoft.Toolkit.Uwp.dll = 103,424
+ Lib (self): Microsoft.Toolkit.Uwp.UI.Animations.dll = 163,840
+ Additional: Microsoft.Toolkit.Uwp.UI.dll = 151,552
  -----------------COMPILED----------------
  App Diff: (.dll) = 4,092,416
  App Diff: (.exe) = 0
  Size Diff: AppxBundleManifest.xml = 25
  Size Diff: AppxBlockMap.xml = 4,573
  Size Diff: AppxManifest.xml = 24
  Size Diff: resources.pri = 2,480
  -----------------------------------------

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Pull Request has been submitted to the documentation repository instructions. Link:
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

[ghost]

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[ghost]

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[Sergio0694]

I think the Ci status might have gotten stuck there? All checks have passed but the PR isn't marked as ready to merge yet.
If you could just merge it manually I can then rebase #3796 and get that ready for review as well 🙂