feat: remove webapi in favor of a smaller polyfill (#7840)

* feat: remove webapi in favor of a smaller polyfill

* test: remove old test

* test: 🤦‍♀️

* chore: changeset

Author: Princesseuh

.changeset/spicy-eels-rush.md

@@ -0,0 +1,8 @@
+---
+'astro': major
+'@astrojs/netlify': major
+'@astrojs/vercel': major
+'@astrojs/node': major
+---
+
+Reduced the amount of polyfills provided by Astro. Astro will no longer provide (no-op) polyfills for several web apis such as HTMLElement, Image or Document. If you need access to those APIs on the server, we recommend using more proper polyfills available on npm.

.eslintignore

@@ -2,7 +2,6 @@
 packages/**/*.min.js
 packages/**/dist/**/*
 packages/**/fixtures/**/*
-packages/webapi/**/*
 packages/astro/vendor/vite/**/*
 examples/**/*
 scripts/**/*

.prettierignore

@@ -22,5 +22,4 @@ benchmark/results/
 .changeset
 
 # Files
-packages/webapi/mod.d.ts
 pnpm-lock.yaml

benchmark/packages/timer/package.json

@@ -23,7 +23,6 @@
     "dev": "astro-scripts dev \"src/**/*.ts\""
   },
   "dependencies": {
-    "@astrojs/webapi": "workspace:*",
     "server-destroy": "^1.0.1"
   },
   "peerDependencies": {

benchmark/packages/timer/src/server.ts

@@ -1,11 +1,8 @@
-import { polyfill } from '@astrojs/webapi';
 import type { SSRManifest } from 'astro';
-import { NodeApp } from 'astro/app/node';
+import { NodeApp, applyPolyfills } from 'astro/app/node';
 import type { IncomingMessage, ServerResponse } from 'node:http';
 
-polyfill(globalThis, {
-	exclude: 'window document',
-});
+applyPolyfills();
 
 export function createExports(manifest: SSRManifest) {
 	const app = new NodeApp(manifest);

package.json

@@ -73,7 +73,6 @@
     }
   },
   "dependencies": {
-    "@astrojs/webapi": "workspace:*",
     "astro-benchmark": "workspace:*"
   },
   "devDependencies": {

packages/astro/package.json

@@ -120,7 +120,6 @@
     "@astrojs/language-server": "^1.0.0",
     "@astrojs/markdown-remark": "^2.2.1",
     "@astrojs/telemetry": "^2.1.1",
-    "@astrojs/webapi": "^2.2.0",
     "@babel/core": "^7.22.5",
     "@babel/generator": "^7.22.5",
     "@babel/parser": "^7.22.5",

packages/astro/src/core/app/node.ts

@@ -6,6 +6,7 @@ import { IncomingMessage } from 'node:http';
 import { TLSSocket } from 'node:tls';
 import { deserializeManifest } from './common.js';
 import { App, type MatchOptions } from './index.js';
+export { apply as applyPolyfills } from '../polyfill.js';
 
 const clientAddressSymbol = Symbol.for('astro.clientAddress');
 

packages/astro/src/core/polyfill.ts

@@ -1,8 +1,21 @@
-import { polyfill } from '@astrojs/webapi';
+import { File } from 'node:buffer';
+import crypto from 'node:crypto';
+
+// NOTE: This file does not intend to polyfill everything that exists, its main goal is to make life easier
+// for users deploying to runtime that do support these features. In the future, we hope for this file to disappear.
 
 export function apply() {
-	// polyfill WebAPIs for Node.js runtime
-	polyfill(globalThis, {
-		exclude: 'window document',
-	});
+	// Remove when Node 18 is dropped for Node 20
+	if (!globalThis.crypto) {
+		Object.defineProperty(globalThis, 'crypto', {
+			value: crypto.webcrypto,
+		});
+	}
+
+	// Remove when Node 18 is dropped for Node 20
+	if (!globalThis.File) {
+		Object.defineProperty(globalThis, 'File', {
+			value: File,
+		});
+	}
 }