Remove markdown component (#7931)

Author: bluwy

.changeset/gentle-meals-crash.md

@@ -0,0 +1,9 @@
+---
+'astro': major
+---
+
+Remove support for `Astro.__renderMarkdown` which is used by `@astrojs/markdown-component`. 
+
+The `<Markdown />` component was deprecated in Astro v1 and is completely removed in v3. This integration must now be removed from your project.
+
+As an alternative, you can use community packages that provide a similar component like https://github.com/natemoo-re/astro-remote instead.

.changeset/pre.json

@@ -27,7 +27,6 @@
     "@astrojs/vercel": "3.7.4",
     "@astrojs/vue": "2.2.1",
     "@astrojs/internal-helpers": "0.1.1",
-    "@astrojs/markdown-component": "1.0.5",
     "@astrojs/markdown-remark": "2.2.1",
     "@astrojs/telemetry": "2.1.1",
     "@astrojs/underscore-redirects": "0.2.0"

packages/astro/src/core/app/index.ts

@@ -88,7 +88,6 @@ export class App {
 		return createEnvironment({
 			adapterName: this.#manifest.adapterName,
 			logging: this.#logging,
-			markdown: this.#manifest.markdown,
 			mode: 'production',
 			compressHTML: this.#manifest.compressHTML,
 			renderers: this.#manifest.renderers,

packages/astro/src/core/app/types.ts

@@ -1,4 +1,3 @@
-import type { MarkdownRenderingOptions } from '@astrojs/markdown-remark';
 import type {
 	RouteData,
 	SerializedRouteData,
@@ -40,7 +39,6 @@ export type SSRManifest = {
 	base: string;
 	compressHTML: boolean;
 	assetsPrefix?: string;
-	markdown: MarkdownRenderingOptions;
 	renderers: SSRLoadedRenderer[];
 	/**
 	 * Map of directive name (e.g. `load`) to the directive script code

packages/astro/src/core/build/generate.ts

@@ -507,7 +507,6 @@ async function generatePath(
 	const env = createEnvironment({
 		adapterName: manifest.adapterName,
 		logging,
-		markdown: manifest.markdown,
 		mode: opts.mode,
 		renderers: manifest.renderers,
 		clientDirectives: manifest.clientDirectives,
@@ -619,7 +618,6 @@ export function createBuildManifest(
 		entryModules: Object.fromEntries(internals.entrySpecifierToBundleMap.entries()),
 		routes: [],
 		adapterName: '',
-		markdown: settings.config.markdown,
 		clientDirectives: settings.clientDirectives,
 		compressHTML: settings.config.compressHTML,
 		renderers,

packages/astro/src/core/build/plugins/plugin-ssr.ts

@@ -489,7 +489,6 @@ function buildManifest(
 		base: settings.config.base,
 		compressHTML: settings.config.compressHTML,
 		assetsPrefix: settings.config.build.assetsPrefix,
-		markdown: settings.config.markdown,
 		componentMetadata: Array.from(internals.componentMetadata),
 		renderers: [],
 		clientDirectives: Array.from(settings.clientDirectives),

packages/astro/src/core/render/core.ts

@@ -42,7 +42,6 @@ async function renderPage({ mod, renderContext, env, cookies }: RenderPage) {
 		links: renderContext.links,
 		styles: renderContext.styles,
 		logging: env.logging,
-		markdown: env.markdown,
 		params: renderContext.params,
 		pathname: renderContext.pathname,
 		componentMetadata: renderContext.componentMetadata,

packages/astro/src/core/render/environment.ts

@@ -1,4 +1,3 @@
-import type { MarkdownRenderingOptions } from '@astrojs/markdown-remark';
 import type { AstroSettings, RuntimeMode, SSRLoadedRenderer } from '../../@types/astro';
 import type { LogOptions } from '../logger/core.js';
 import type { ModuleLoader } from '../module-loader';
@@ -16,10 +15,6 @@ export interface Environment {
 	adapterName?: string;
 	/** logging options */
 	logging: LogOptions;
-	/**
-	 * Used to support `Astro.__renderMarkdown` for legacy `<Markdown />` component
-	 */
-	markdown: MarkdownRenderingOptions;
 	/** "development" or "production" */
 	mode: RuntimeMode;
 	compressHTML: boolean;

packages/astro/src/core/render/result.ts

@@ -1,4 +1,3 @@
-import type { MarkdownRenderingOptions } from '@astrojs/markdown-remark';
 import type {
 	AstroGlobal,
 	AstroGlobalPartial,
@@ -27,10 +26,6 @@ export interface CreateResultArgs {
 	 */
 	ssr: boolean;
 	logging: LogOptions;
-	/**
-	 * Used to support `Astro.__renderMarkdown` for legacy `<Markdown />` component
-	 */
-	markdown: MarkdownRenderingOptions;
 	params: Params;
 	pathname: string;
 	renderers: SSRLoadedRenderer[];
@@ -128,10 +123,8 @@ class Slots {
 	}
 }
 
-let renderMarkdown: any = null;
-
 export function createResult(args: CreateResultArgs): SSRResult {
-	const { markdown, params, request, resolve, locals } = args;
+	const { params, request, resolve, locals } = args;
 
 	const url = new URL(request.url);
 	const headers = new Headers();
@@ -222,31 +215,6 @@ export function createResult(args: CreateResultArgs): SSRResult {
 				slots: astroSlots as unknown as AstroGlobal['slots'],
 			};
 
-			Object.defineProperty(Astro, '__renderMarkdown', {
-				// Ensure this API is not exposed to users
-				enumerable: false,
-				writable: false,
-				// TODO: Remove this hole "Deno" logic once our plugin gets Deno support
-				value: async function (content: string, opts: MarkdownRenderingOptions) {
-					// @ts-expect-error
-					if (typeof Deno !== 'undefined') {
-						throw new Error('Markdown is not supported in Deno SSR');
-					}
-
-					if (!renderMarkdown) {
-						// The package is saved in this variable because Vite is too smart
-						// and will try to inline it in buildtime
-						let astroRemark = '@astrojs/';
-						astroRemark += 'markdown-remark';
-
-						renderMarkdown = (await import(astroRemark)).renderMarkdown;
-					}
-
-					const { code } = await renderMarkdown(content, { ...markdown, ...(opts ?? {}) });
-					return code;
-				},
-			});
-
 			return Astro;
 		},
 		resolve,

packages/astro/src/vite-plugin-astro-server/environment.ts

@@ -17,7 +17,6 @@ export function createDevelopmentEnvironment(
 	let env = createEnvironment({
 		adapterName: manifest.adapterName,
 		logging,
-		markdown: manifest.markdown,
 		mode,
 		// This will be overridden in the dev server
 		renderers: [],